From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg
Date: Mon, 15 Apr 2013 02:56:13 +0100 (BST)
Message-ID: <1365990973.28177.YahooMailClassic@web172303.mail.ir2.yahoo.com>
References: <1365990674.1878.21.camel@joe-AO722>
Reply-To: htl10@users.sourceforge.net
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Joe Perches <joe@perches.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1365990674.1878.21.camel@joe-AO722>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

--- On Mon, 15/4/13, Joe Perches <joe@perches.com> wrote:

> On Mon, 2013-04-15 at 01:53 +0100,
> Hin-Tak Leung wrote:
> > --- On Mon, 8/4/13, Joe Perches <joe@perches.com>
> wrote:
> > > Use a more current logging style.
> []
> > I have been sitting on a patch which changes this part
> of the code to dynamic debugging, and it is much simplier.
> Just:
> > #define dprint(flg, fmt, args...) \
> > -=A0 =A0 =A0=A0=A0if (flg &
> DBG_MASK) \
> > -=A0 =A0 =A0 =A0 =A0 =A0
> =A0=A0=A0printk(fmt , ## args)
> > +=A0 =A0 =A0 =A0 =A0 =A0
> =A0=A0=A0pr_debug(fmt , ## args)
>=20
> This change wouldn't work well as it would make a mess
> of output that uses no prefix (ie: emits at KERN_DEFAULT)
> with output that uses KERN_DEBUG
>=20
> That's the reason for _dbg and _dbg_cont.

Hmm, I don't get it. Is there any *existing* use of dprint in the hfplu=
s code which is affected by your comment? Or is this another general st=
ylistic comment? i.e. "this does not work in general"?