From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Date: Sun, 14 Apr 2013 21:00:09 -0700 Message-ID: <1365998409.1878.29.camel@joe-AO722> References: <1365997619.11055.YahooMailClassic@web172306.mail.ir2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Vyacheslav Dubeyko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: htl10@users.sourceforge.net Return-path: In-Reply-To: <1365997619.11055.YahooMailClassic@web172306.mail.ir2.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2013-04-15 at 04:46 +0100, Hin-Tak Leung wrote: > > By converting this dprint() to pr_debug(), it would > > print out on a multiple lines, one for each read. > > > > That's why it should use a mechanism like dbg_cont. > > > > btw: there is no current pr_debug_cont mechanism. > > That's rubbish. Don't be silly. > dprint() are compiled in/out debug printing statements, > and are entirely suppressed in unmodified kernel source Of course. > I am not saying what I have in private is correct Then your original post wasn't useful either. > What I am saying is that the code snipplet I posted is functional: Lots of code is functional, I prefer functional and correct though. cheers, Joe