From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg
Date: Mon, 15 Apr 2013 05:22:18 +0100 (BST)
Message-ID: <1365999738.30513.YahooMailClassic@web172302.mail.ir2.yahoo.com>
References: <1365998409.1878.29.camel@joe-AO722>
Reply-To: htl10@users.sourceforge.net
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Joe Perches <joe@perches.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from nm10.bullet.mail.ird.yahoo.com ([77.238.189.39]:46024 "HELO
	nm10.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1751304Ab3DOEWU convert rfc822-to-8bit
	(ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 15 Apr 2013 00:22:20 -0400
In-Reply-To: <1365998409.1878.29.camel@joe-AO722>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

--- On Mon, 15/4/13, Joe Perches <joe@perches.com> wrote:

> On Mon, 2013-04-15 at 04:46 +0100,
> Hin-Tak Leung wrote:
> > > By converting this dprint() to pr_debug(), it
> would
> > > print out on a multiple lines, one for each read.
> > > 
> > > That's why it should use a mechanism like
> dbg_cont.
> > > 
> > > btw: there is no current pr_debug_cont mechanism.
> > 
> > That's rubbish.
> 
> Don't be silly.
> 
> > dprint() are compiled in/out debug printing
> statements,
> > and are entirely suppressed in unmodified kernel
> source
> 
> Of course.
> 
> > I am not saying what I have in private is correct
> 
> Then your original post wasn't useful either.
> 
> > What I am saying is that the code snipplet I posted is
> functional:
> 
> Lots of code is functional, I prefer functional
> and correct though.
> 
> cheers, Joe

Hmm, you obvious has a different meaning of "functional" than I. How is converting a few hundred lines of "print nothing" to another few hundred lines of "print nothing" functional? What does it achieve?

I have already voiced my (admittedly selfish) concern: changing a few hundred lines of "print nothing" to another few hundred lines of "print nothing" means some of us who have substantial work-in-progress patches needs to spend a fair amount of time on rebase, and manually resolving conflicts from rebase.