From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Date: Sun, 14 Apr 2013 21:38:28 -0700 Message-ID: <1366000708.1878.34.camel@joe-AO722> References: <1365999738.30513.YahooMailClassic@web172302.mail.ir2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Vyacheslav Dubeyko , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: htl10@users.sourceforge.net Return-path: In-Reply-To: <1365999738.30513.YahooMailClassic@web172302.mail.ir2.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2013-04-15 at 05:22 +0100, Hin-Tak Leung wrote: > How is converting a few hundred lines of "print nothing" to > another few hundred lines of "print nothing" functional? > What does it achieve? Standardization of output style when enabled. Easier conversion to pr_debug/dynamic_debugging. Emitting at KERN_DEBUG when enabled. Besides, I was also doing the other logging conversions at the same time to prefix hfs differently than hfsplus. I don't really care much when this stuff is done, (it took about 10 minutes and it's about all automatic and scripted) but I do think it should be done.