From: "J. Bruce Fields" <bfields@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 00/12] Implement NFSv4 delegations, take 7
Date: Tue, 16 Apr 2013 21:46:12 -0400 [thread overview]
Message-ID: <1366163185-10317-1-git-send-email-bfields@redhat.com> (raw)
From: "J. Bruce Fields" <bfields@redhat.com>
This is just a rebase of the previous posting. As far as I can tell, it's
ready for 3.10. Introduction (mostly repeated) follows:
This patch series implements read delegations, which allow NFSv4 clients
to perform read opens without contacting the server, by promising to
call back to clients before modifying the data, metadata, or set of
links pointing to a file.
The main recent change was in response to review from Linus, who didn't
want us to hang under directory i_mutex's on timeouts communicating with
unresponsive clients.
So, this version of the series drops the i_mutex before waiting. The
logic ends up looking something like:
acquire locks
look up inode
test for delegation; if found:
take reference on inode
release locks
wait for delegation break
drop reference on inode
retry
The initial test for a delegation happens after the lock on the
delegated inode is acquired, but additional directory mutexes may have
been acquired further up the call stack. I therefore add a "struct
inode **" argument to any intervening functions, which we use to pass
the inode back up to the caller in the case it needs to wait for the
delegation to be broken.
I also allow callers to pass in NULL for the "struct inode **" argument
to indicate they'd rather just fail than wait for a delegation. For
example, as long as ecryptfs isn't exportable I assume they'd rather not
see retry logic there that they won't use. But I may have misjudged in
some of these cases.
J. Bruce Fields (12):
vfs: pull ext4's double-i_mutex-locking into common code
vfs: don't use PARENT/CHILD lock classes for non-directories
vfs: rename I_MUTEX_QUOTA now that it's not used for quotas
vfs: take i_mutex on renamed file
locks: introduce new FL_DELEG lock flag
locks: implement delegations
namei: minor vfs_unlink cleanup
locks: break delegations on unlink
locks: helper functions for delegation breaking
locks: break delegations on rename
locks: break delegations on link
locks: break delegations on any attribute modification
Documentation/filesystems/directory-locking | 31 ++++++++---
drivers/base/devtmpfs.c | 6 +-
fs/attr.c | 5 +-
fs/cachefiles/interface.c | 4 +-
fs/cachefiles/namei.c | 4 +-
fs/ecryptfs/inode.c | 6 +-
fs/ext4/move_extent.c | 40 +-------------
fs/hpfs/namei.c | 2 +-
fs/inode.c | 35 +++++++++++-
fs/locks.c | 51 +++++++++++++----
fs/namei.c | 79 +++++++++++++++++++++------
fs/nfsd/nfs4state.c | 2 +-
fs/nfsd/vfs.c | 14 +++--
fs/open.c | 21 +++++--
fs/utimes.c | 9 ++-
include/linux/fs.h | 72 ++++++++++++++++++++----
ipc/mqueue.c | 2 +-
17 files changed, 271 insertions(+), 112 deletions(-)
--
1.7.9.5
next reply other threads:[~2013-04-17 1:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 1:46 J. Bruce Fields [this message]
2013-04-17 1:46 ` [PATCH 01/12] vfs: pull ext4's double-i_mutex-locking into common code J. Bruce Fields
2013-04-17 1:46 ` [PATCH 03/12] vfs: rename I_MUTEX_QUOTA now that it's not used for quotas J. Bruce Fields
[not found] ` <1366163185-10317-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-17 1:46 ` [PATCH 02/12] vfs: don't use PARENT/CHILD lock classes for non-directories J. Bruce Fields
2013-04-17 1:46 ` [PATCH 04/12] vfs: take i_mutex on renamed file J. Bruce Fields
2013-04-17 1:46 ` [PATCH 07/12] namei: minor vfs_unlink cleanup J. Bruce Fields
2013-04-17 1:46 ` [PATCH 10/12] locks: break delegations on rename J. Bruce Fields
2013-04-17 1:46 ` [PATCH 05/12] locks: introduce new FL_DELEG lock flag J. Bruce Fields
2013-04-17 1:46 ` [PATCH 06/12] locks: implement delegations J. Bruce Fields
2013-04-17 1:46 ` [PATCH 08/12] locks: break delegations on unlink J. Bruce Fields
2013-04-17 1:46 ` [PATCH 09/12] locks: helper functions for delegation breaking J. Bruce Fields
2013-04-17 1:46 ` [PATCH 11/12] locks: break delegations on link J. Bruce Fields
2013-04-17 1:46 ` [PATCH 12/12] locks: break delegations on any attribute modification J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366163185-10317-1-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).