From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH v4 4/7] f2fs: add tracepoints for GC threads Date: Tue, 23 Apr 2013 19:39:43 +0900 Message-ID: <1366713583.31792.13.camel@kjgkr> References: <1366388958-18915-1-git-send-email-linkinjeon@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-RIbw+vlERuNPlQihbMfo" Cc: rostedt@goodmis.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Pankaj Kumar To: Namjae Jeon Return-path: In-reply-to: <1366388958-18915-1-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-RIbw+vlERuNPlQihbMfo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =46rom 8e46b3ed11b750a740fec0a313ad9118059fc37b Mon Sep 17 00:00:00 2001 From: Namjae Jeon Date: Tue, 23 Apr 2013 16:42:53 +0900 Subject: [PATCH 4/7] f2fs: add tracepoints for GC threads Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Add tracepoints for tracing the garbage collector threads in f2fs with status of collection & type. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Acked-by: Steven Rostedt [Jaegeuk: modify slightly to show information] Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 5 +++ include/trace/events/f2fs.h | 75 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 37b05e1..1ca3324 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -23,6 +23,7 @@ #include "node.h" #include "segment.h" #include "gc.h" +#include =20 static struct kmem_cache *winode_slab; =20 @@ -301,6 +302,10 @@ got_it: set_bit(secno, dirty_i->victim_secmap); } *result =3D (p.min_segno / p.ofs_unit) * p.ofs_unit; + + trace_f2fs_get_victim(sbi->sb, type, gc_type, &p, + sbi->cur_victim_sec, + prefree_segments(sbi), free_segments(sbi)); } mutex_unlock(&dirty_i->seglist_lock); =20 diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index 924e69a..6f7cf7a 100644 --- a/include/trace/events/f2fs.h +++ b/include/trace/events/f2fs.h @@ -18,6 +18,33 @@ { WRITE_FLUSH, "WRITE_FLUSH" }, \ { WRITE_FUA, "WRITE_FUA" }) =20 +#define show_data_type(type) \ + __print_symbolic(type, \ + { CURSEG_HOT_DATA, "Hot DATA" }, \ + { CURSEG_WARM_DATA, "Warm DATA" }, \ + { CURSEG_COLD_DATA, "Cold DATA" }, \ + { CURSEG_HOT_NODE, "Hot NODE" }, \ + { CURSEG_WARM_NODE, "Warm NODE" }, \ + { CURSEG_COLD_NODE, "Cold NODE" }, \ + { NO_CHECK_TYPE, "No TYPE" }) + +#define show_gc_type(type) \ + __print_symbolic(type, \ + { FG_GC, "Foreground GC" }, \ + { BG_GC, "Background GC" }) + +#define show_alloc_mode(type) \ + __print_symbolic(type, \ + { LFS, "LFS-mode" }, \ + { SSR, "SSR-mode" }) + +#define show_victim_policy(type) \ + __print_symbolic(type, \ + { GC_GREEDY, "Greedy" }, \ + { GC_CB, "Cost-Benefit" }) + +struct victim_sel_policy; + DECLARE_EVENT_CLASS(f2fs__inode, =20 TP_PROTO(struct inode *inode), @@ -439,6 +466,54 @@ TRACE_EVENT(f2fs_get_data_block, __entry->ret) ); =20 +TRACE_EVENT(f2fs_get_victim, + + TP_PROTO(struct super_block *sb, int type, int gc_type, + struct victim_sel_policy *p, unsigned int pre_victim, + unsigned int prefree, unsigned int free), + + TP_ARGS(sb, type, gc_type, p, pre_victim, prefree, free), + + TP_STRUCT__entry( + __field(dev_t, dev) + __field(int, type) + __field(int, gc_type) + __field(int, alloc_mode) + __field(int, gc_mode) + __field(unsigned int, victim) + __field(unsigned int, ofs_unit) + __field(unsigned int, pre_victim) + __field(unsigned int, prefree) + __field(unsigned int, free) + ), + + TP_fast_assign( + __entry->dev =3D sb->s_dev; + __entry->type =3D type; + __entry->gc_type =3D gc_type; + __entry->alloc_mode =3D p->alloc_mode; + __entry->gc_mode =3D p->gc_mode; + __entry->victim =3D p->min_segno; + __entry->ofs_unit =3D p->ofs_unit; + __entry->pre_victim =3D pre_victim; + __entry->prefree =3D prefree; + __entry->free =3D free; + ), + + TP_printk("dev =3D (%d,%d), type =3D %s, policy =3D (%s, %s, %s), victim = =3D % u " + "ofs_unit =3D %u, pre_victim_secno =3D %d, prefree =3D %u, free =3D %u", + show_dev(__entry), + show_data_type(__entry->type), + show_gc_type(__entry->gc_type), + show_alloc_mode(__entry->alloc_mode), + show_victim_policy(__entry->gc_mode), + __entry->victim, + __entry->ofs_unit, + (int)__entry->pre_victim, + __entry->prefree, + __entry->free) +); + #endif /* _TRACE_F2FS_H */ =20 /* This part must be outside protection */ --=20 1.8.1.3.566.gaa39828 --=20 Jaegeuk Kim Samsung --=-RIbw+vlERuNPlQihbMfo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRdmTvAAoJEEAUqH6CSFDSSSMP+wecjF+4COAUvkk/TzPwPj9g mZEQKVhSBpWaRDVevYequJo1G5bf7YB06//MVMKYj6JGr7JRw57BnXFGbcV6w6aT Xafbyf8Ust9Qca6pCnwE37Mz1ezx8OH0Ob1t/91RhzEtOJ81Pu9rXOkEHiWXdXqO ueYqdy3p2kXuiesY6OwxrLkub7oivWNDgmCYsOJv5UrDBw5cFhLHGVChvIbNH6yd 06yIE1e8O/HzoqHPwdy08XF1KA6Y6peucBps8U3H7hrOY+LjJmnguuF/aeK0b7Pd Rq4eO0wU7rGRj3aO52aMYd1UvzlFijlEe7McVQ9aB05zQzhd1by0nzXTzYtFvnp4 6PS+EL2/640kE/iet115ZDHQWMqal77Vkl/V4ziwtkff63j03ROGPlehrDLzYd1i vsbxyyiaaamBX01+Ayj7wTEImtPO+qH2iCfCBgrF+v0m7j3NnrzTmq/gr0sHx8uZ anZtMQAdycsGNvcaty8ANTOzwyfhs4B1Q05idJks98o2Qc6AZIqq7BYcdiaPfldb pZ11yTQDdtnGCzbcsogOf6ZQvu3ZyXOFf03PMa5giSE44Pq5GVPlxqMxsn4/7yyK kVm4z87/P498MIGFpmlJXybqMQ12qX1wO2kUzJ2Ku/AK1vs9DazDCPvJaQDGhOrr TpKWQlKhmkWe3FYWzVG2 =6e1s -----END PGP SIGNATURE----- --=-RIbw+vlERuNPlQihbMfo--