* [PATCH v2 05/10] epoll: use freezable blocking call
[not found] <1367458508-9133-1-git-send-email-ccross@android.com>
@ 2013-05-02 1:35 ` Colin Cross
2013-05-02 1:35 ` [PATCH v2 06/10] select: " Colin Cross
1 sibling, 0 replies; 2+ messages in thread
From: Colin Cross @ 2013-05-02 1:35 UTC (permalink / raw)
To: linux-pm
Cc: linux-kernel, Rafael J. Wysocki, arve, Tejun Heo, Oleg Nesterov,
Colin Cross, Alexander Viro, linux-fsdevel
Avoid waking up every thread sleeping in an epoll_wait call during
suspend and resume by calling a freezable blocking call. Previous
patches modified the freezer to avoid sending wakeups to threads
that are blocked in freezable blocking calls.
This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.
Signed-off-by: Colin Cross <ccross@android.com>
---
fs/eventpoll.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 9fec183..65245e7 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -34,6 +34,7 @@
#include <linux/mutex.h>
#include <linux/anon_inodes.h>
#include <linux/device.h>
+#include <linux/freezer.h>
#include <asm/uaccess.h>
#include <asm/io.h>
#include <asm/mman.h>
@@ -1543,7 +1544,8 @@ fetch_events:
}
spin_unlock_irqrestore(&ep->lock, flags);
- if (!schedule_hrtimeout_range(to, slack, HRTIMER_MODE_ABS))
+ if (!freezable_schedule_hrtimeout_range(to, slack,
+ HRTIMER_MODE_ABS))
timed_out = 1;
spin_lock_irqsave(&ep->lock, flags);
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 06/10] select: use freezable blocking call
[not found] <1367458508-9133-1-git-send-email-ccross@android.com>
2013-05-02 1:35 ` [PATCH v2 05/10] epoll: use freezable blocking call Colin Cross
@ 2013-05-02 1:35 ` Colin Cross
1 sibling, 0 replies; 2+ messages in thread
From: Colin Cross @ 2013-05-02 1:35 UTC (permalink / raw)
To: linux-pm
Cc: linux-kernel, Rafael J. Wysocki, arve, Tejun Heo, Oleg Nesterov,
Colin Cross, Alexander Viro, linux-fsdevel
Avoid waking up every thread sleeping in a select call during
suspend and resume by calling a freezable blocking call. Previous
patches modified the freezer to avoid sending wakeups to threads
that are blocked in freezable blocking calls.
This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.
Signed-off-by: Colin Cross <ccross@android.com>
---
fs/select.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/select.c b/fs/select.c
index 8c1c96c..6b14dc7 100644
--- a/fs/select.c
+++ b/fs/select.c
@@ -27,6 +27,7 @@
#include <linux/rcupdate.h>
#include <linux/hrtimer.h>
#include <linux/sched/rt.h>
+#include <linux/freezer.h>
#include <asm/uaccess.h>
@@ -236,7 +237,8 @@ int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
set_current_state(state);
if (!pwq->triggered)
- rc = schedule_hrtimeout_range(expires, slack, HRTIMER_MODE_ABS);
+ rc = freezable_schedule_hrtimeout_range(expires, slack,
+ HRTIMER_MODE_ABS);
__set_current_state(TASK_RUNNING);
/*
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread