From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Haicheng Li <haicheng.lee@gmail.com>
Subject: Re: [PATCH 4/4] f2fs: optimize build_free_nids()
Date: Tue, 07 May 2013 19:33:59 +0900 [thread overview]
Message-ID: <1367922839.16581.42.camel@kjgkr> (raw)
In-Reply-To: <1367853344-28938-5-git-send-email-haicheng.li@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
Hi,
2013-05-06 (월), 23:15 +0800, Haicheng Li:
> When nm_i->fcnt > 2 * MAX_FREE_NIDS, stop scanning other NAT pages.
>
> Signed-off-by: Haicheng Li <haicheng.li@linux.intel.com>
> ---
> fs/f2fs/node.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 1fe3fe2..3136224 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1342,6 +1342,8 @@ static void build_free_nids(struct f2fs_sb_info *sbi)
> if (nid >= nm_i->max_nid)
> nid = 0;
>
> + if (nm_i->fcnt > 2 * MAX_FREE_NIDS)
> + break;
Could you explain when this can happen?
IMO, this is an unnecessary condition check, since the below condition
that includes FREE_NID_PAGES already limits the number of free nids.
Thanks,
> if (i++ == FREE_NID_PAGES)
> break;
> }
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-07 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 15:15 [PATCH V2 0/4] f2fs: various optimization & bugfixing for node management Haicheng Li
2013-05-06 15:15 ` [PATCH 1/4] f2fs: bugfix for alloc_nid_failed() Haicheng Li
2013-05-06 15:15 ` [PATCH 2/4] f2fs: code cleanup for scan_nat_page() and build_free_nids() Haicheng Li
2013-05-06 15:15 ` [PATCH 3/4] f2fs: optimize scan_nat_page() Haicheng Li
2013-05-07 10:36 ` Jaegeuk Kim
2013-05-08 5:31 ` Haicheng Li
2013-05-06 15:15 ` [PATCH 4/4] f2fs: optimize build_free_nids() Haicheng Li
2013-05-07 10:33 ` Jaegeuk Kim [this message]
2013-05-08 6:24 ` Haicheng Li
2013-05-08 9:50 ` Jaegeuk Kim
2013-05-08 11:50 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367922839.16581.42.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=haicheng.lee@gmail.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).