From: Denis Efremov <yefremov.denis@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Denis Efremov <yefremov.denis@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
trivial@kernel.org, ldv-project@linuxtesting.org
Subject: [PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions
Date: Thu, 9 May 2013 11:58:24 +0400 [thread overview]
Message-ID: <1368086323-9412-2-git-send-email-yefremov.denis@gmail.com> (raw)
In-Reply-To: <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
fs/bio.c | 2 +-
fs/block_dev.c | 2 +-
fs/buffer.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/bio.c b/fs/bio.c
index b96fc6c..4e1235f 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -402,7 +402,7 @@ void bio_put(struct bio *bio)
}
EXPORT_SYMBOL(bio_put);
-inline int bio_phys_segments(struct request_queue *q, struct bio *bio)
+int bio_phys_segments(struct request_queue *q, struct bio *bio)
{
if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
diff --git a/fs/block_dev.c b/fs/block_dev.c
index ce08de7..799d879 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -42,7 +42,7 @@ static inline struct bdev_inode *BDEV_I(struct inode *inode)
return container_of(inode, struct bdev_inode, vfs_inode);
}
-inline struct block_device *I_BDEV(struct inode *inode)
+struct block_device *I_BDEV(struct inode *inode)
{
return &BDEV_I(inode)->bdev;
}
diff --git a/fs/buffer.c b/fs/buffer.c
index bc1fe14..c3cfe44 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -54,7 +54,7 @@ void init_buffer(struct buffer_head *bh, bh_end_io_t *handler, void *private)
}
EXPORT_SYMBOL(init_buffer);
-inline void touch_buffer(struct buffer_head *bh)
+void touch_buffer(struct buffer_head *bh)
{
trace_block_touch_buffer(bh);
mark_page_accessed(bh->b_page);
--
1.8.1.4
next parent reply other threads:[~2013-05-09 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
2013-05-09 7:58 ` Denis Efremov [this message]
2013-05-09 8:07 ` [PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions Al Viro
2013-05-09 8:42 ` Denis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368086323-9412-2-git-send-email-yefremov.denis@gmail.com \
--to=yefremov.denis@gmail.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).