From: zwu.kernel@gmail.com
To: viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, sekharan@us.ibm.com,
linuxram@us.ibm.com, david@fromorbit.com, dsterba@suse.cz,
gregkh@linuxfoundation.org, paulmck@linux.vnet.ibm.com,
chris.mason@fusionio.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: [PATCH v2 04/12] VFS hot tracking: register one shrinker
Date: Tue, 14 May 2013 08:59:36 +0800 [thread overview]
Message-ID: <1368493184-5939-5-git-send-email-zwu.kernel@gmail.com> (raw)
In-Reply-To: <1368493184-5939-1-git-send-email-zwu.kernel@gmail.com>
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Register a shrinker to control the amount of memory that
is used in tracking hot regions. If we are throwing inodes
out of memory due to memory pressure, we most definitely are
going to need to reduce the amount of memory the tracking
code is using, even if it means losing useful information
That is, the shrinker accelerates the aging process.
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
fs/hot_tracking.c | 58 ++++++++++++++++++++++++++++++++++++++++++++
include/linux/hot_tracking.h | 2 ++
2 files changed, 60 insertions(+)
diff --git a/fs/hot_tracking.c b/fs/hot_tracking.c
index 2742d9e..af4498c 100644
--- a/fs/hot_tracking.c
+++ b/fs/hot_tracking.c
@@ -100,6 +100,7 @@ static void hot_comm_item_unlink(struct hot_info *root,
list_del_rcu(&ci->track_list);
spin_unlock(&root->m_lock);
+ atomic_dec(&root->hot_map_nr);
hot_comm_item_put(ci);
}
@@ -517,6 +518,7 @@ static int hot_map_update(struct hot_info *root,
else {
u32 flags = ci->hot_freq_data.flags;
+ atomic_inc(&root->hot_map_nr);
hot_comm_item_get(ci);
spin_lock(&root->m_lock);
@@ -642,6 +644,55 @@ void __init hot_cache_init(void)
}
EXPORT_SYMBOL_GPL(hot_cache_init);
+static void hot_prune_map(struct hot_info *root, long nr)
+{
+ int i;
+
+ for (i = 0; i < MAP_SIZE; i++) {
+ struct hot_comm_item *ci;
+ unsigned long prev_nr;
+
+ rcu_read_lock();
+ if (list_empty(&root->hot_map[TYPE_INODE][i])) {
+ rcu_read_unlock();
+ continue;
+ }
+
+ list_for_each_entry_rcu(ci, &root->hot_map[TYPE_INODE][i],
+ track_list) {
+ prev_nr = atomic_read(&root->hot_map_nr);
+ hot_comm_item_unlink(root, ci);
+ nr -= (prev_nr - atomic_read(&root->hot_map_nr));
+ if (nr <= 0)
+ break;
+ }
+ rcu_read_unlock();
+
+ if (nr <= 0)
+ break;
+ }
+
+ return;
+}
+
+/* The shrinker callback function */
+static int hot_track_prune(struct shrinker *shrink,
+ struct shrink_control *sc)
+{
+ struct hot_info *root =
+ container_of(shrink, struct hot_info, hot_shrink);
+
+ if (sc->nr_to_scan == 0)
+ return atomic_read(&root->hot_map_nr) / 2;
+
+ if (!(sc->gfp_mask & __GFP_FS))
+ return -1;
+
+ hot_prune_map(root, sc->nr_to_scan);
+
+ return atomic_read(&root->hot_map_nr);
+}
+
/*
* Main function to update i/o access frequencies, and it will be called
* from read/writepages() hooks, which are read_pages(), do_writepages(),
@@ -706,6 +757,7 @@ static struct hot_info *hot_tree_init(struct super_block *sb)
root->hot_inode_tree = RB_ROOT;
spin_lock_init(&root->t_lock);
spin_lock_init(&root->m_lock);
+ atomic_set(&root->hot_map_nr, 0);
for (i = 0; i < MAP_SIZE; i++) {
for (j = 0; j < MAX_TYPES; j++)
@@ -726,6 +778,11 @@ static struct hot_info *hot_tree_init(struct super_block *sb)
queue_delayed_work(root->update_wq, &root->update_work,
msecs_to_jiffies(HOT_UPDATE_INTERVAL * MSEC_PER_SEC));
+ /* Register a shrinker callback */
+ root->hot_shrink.shrink = hot_track_prune;
+ root->hot_shrink.seeks = DEFAULT_SEEKS;
+ register_shrinker(&root->hot_shrink);
+
return root;
}
@@ -737,6 +794,7 @@ static void hot_tree_exit(struct hot_info *root)
struct rb_node *node;
struct hot_comm_item *ci;
+ unregister_shrinker(&root->hot_shrink);
cancel_delayed_work_sync(&root->update_work);
destroy_workqueue(root->update_wq);
diff --git a/include/linux/hot_tracking.h b/include/linux/hot_tracking.h
index c32197b..a78b4fc 100644
--- a/include/linux/hot_tracking.h
+++ b/include/linux/hot_tracking.h
@@ -90,8 +90,10 @@ struct hot_info {
spinlock_t t_lock; /* protect above tree */
struct list_head hot_map[MAX_TYPES][MAP_SIZE]; /* map of inode temp */
spinlock_t m_lock;
+ atomic_t hot_map_nr;
struct workqueue_struct *update_wq;
struct delayed_work update_work;
+ struct shrinker hot_shrink;
};
extern void __init hot_cache_init(void);
--
1.7.11.7
next prev parent reply other threads:[~2013-05-14 0:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 0:59 [PATCH v2 00/12] VFS hot tracking zwu.kernel
2013-05-14 0:59 ` [PATCH v2 01/12] VFS hot tracking: introduce some data structures zwu.kernel
2013-05-14 0:59 ` [PATCH v2 02/12] VFS hot tracking: add i/o freq tracking hooks zwu.kernel
2013-05-14 0:59 ` [PATCH v2 03/12] VFS hot tracking: add one workqueue to update hot map zwu.kernel
2013-05-14 0:59 ` zwu.kernel [this message]
2013-05-14 0:59 ` [PATCH v2 05/12] VFS hot tracking, rcu: introduce one rcu macro for list zwu.kernel
2013-05-14 0:59 ` [PATCH v2 06/12] VFS hot tracking, seq_file: introduce one set of rcu seq_list interfaces zwu.kernel
2013-05-14 0:59 ` [PATCH v2 07/12] VFS hot tracking: add debugfs support zwu.kernel
2013-05-14 0:59 ` [PATCH v2 08/12] VFS hot tracking: add one ioctl interface zwu.kernel
2013-05-14 0:59 ` [PATCH v2 09/12] VFS hot tracking, procfs: add two proc interfaces zwu.kernel
2013-05-14 0:59 ` [PATCH v2 10/12] VFS hot tracking, btrfs: add hot tracking support zwu.kernel
2013-05-14 0:59 ` [PATCH v2 11/12] VFS hot tracking: add documentation zwu.kernel
2013-05-14 0:59 ` [PATCH v2 12/12] VFS hot tracking: add fs hot type support zwu.kernel
2013-05-21 22:55 ` [PATCH v2 00/12] VFS hot tracking Zhi Yong Wu
2013-05-24 3:39 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368493184-5939-5-git-send-email-zwu.kernel@gmail.com \
--to=zwu.kernel@gmail.com \
--cc=chris.mason@fusionio.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sekharan@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wuzhy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).