From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH][Trivial] f2fs: Use list_for_each_entry rather than list_for_each_entry_safe.
Date: Wed, 15 May 2013 13:45:36 +0900 [thread overview]
Message-ID: <1368593136.11843.17.camel@kjgkr> (raw)
In-Reply-To: <519228D6.4070504@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
Hi Jianpeng,
Could you explain why this *should* be changed?
Thanks,
2013-05-14 (화), 20:06 +0800, majianpeng:
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> fs/f2fs/debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
> index 8d99437..0d6c6aa 100644
> --- a/fs/f2fs/debug.c
> +++ b/fs/f2fs/debug.c
> @@ -175,12 +175,12 @@ get_cache:
>
> static int stat_show(struct seq_file *s, void *v)
> {
> - struct f2fs_stat_info *si, *next;
> + struct f2fs_stat_info *si;
> int i = 0;
> int j;
>
> mutex_lock(&f2fs_stat_mutex);
> - list_for_each_entry_safe(si, next, &f2fs_stat_list, stat_list) {
> + list_for_each_entry(si, &f2fs_stat_list, stat_list) {
> char devname[BDEVNAME_SIZE];
>
> update_general_status(si->sbi);
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-15 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 12:06 [PATCH][Trivial] f2fs: Use list_for_each_entry rather than list_for_each_entry_safe majianpeng
2013-05-15 4:45 ` Jaegeuk Kim [this message]
2013-05-15 6:36 ` majianpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368593136.11843.17.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).