linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 02/15] f2fs: remove unnecessary flag set
Date: Mon, 20 May 2013 16:31:30 +0900	[thread overview]
Message-ID: <1369035090.10521.4.camel@kjgkr> (raw)
In-Reply-To: <1369020743-18520-2-git-send-email-jaegeuk.kim@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

Sorry for the noise.
This patch should be ignored.
Thanks,

2013-05-20 (월), 12:32 +0900, Jaegeuk Kim:
> If an inode is recovered with its dentry, it will not invoke __f2fs_add_link,
> since the recovery routine checks its dentry before calling __f2fs_add_link.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> ---
>  fs/f2fs/recovery.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index 2941987..993b601 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -125,11 +125,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
>  			goto next;
>  
>  		entry = get_fsync_inode(head, ino_of_node(page));
> -		if (entry) {
> -			if (IS_INODE(page) && is_dent_dnode(page))
> -				set_inode_flag(F2FS_I(entry->inode),
> -							FI_INC_LINK);
> -		} else {
> +		if (!entry) {
>  			if (IS_INODE(page) && is_dent_dnode(page)) {
>  				err = recover_inode_page(sbi, page);
>  				if (err)

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-05-20  7:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20  3:32 [f2fs-dev] [PATCH 01/15] f2fs: remove redundant assignment Jaegeuk Kim
2013-05-20  3:32 ` [f2fs-dev] [PATCH 02/15] f2fs: remove unnecessary flag set Jaegeuk Kim
2013-05-20  7:31   ` Jaegeuk Kim [this message]
2013-05-20  3:32 ` [f2fs-dev] [PATCH 03/15] f2fs: fix por_doing variable coverage Jaegeuk Kim
2013-05-20  3:32 ` [PATCH 04/15] f2fs: fix BUG_ON during f2fs_evict_inode(dir) Jaegeuk Kim
2013-05-20  3:32 ` [f2fs-dev] [PATCH 05/15] f2fs: remove unnecessary por_doing check Jaegeuk Kim
2013-05-20  3:32 ` [f2fs-dev] [PATCH 06/15] f2fs: skip get_node_page if locked node page is passed Jaegeuk Kim
2013-05-20  3:32 ` [PATCH 07/15] f2fs: change get_new_data_page to pass a locked node page Jaegeuk Kim
2013-05-20  3:32 ` [f2fs-dev] [PATCH 08/15] f2fs: update inode page after creation Jaegeuk Kim
2013-05-20  3:32 ` [PATCH 09/15] f2fs: add debug msgs in the recovery routine Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369035090.10521.4.camel@kjgkr \
    --to=jaegeuk.kim@samsung.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).