From: Jeff Layton <jlayton@redhat.com>
To: viro@zeniv.linux.org.uk, matthew@wil.cx, bfields@fieldses.org
Cc: dhowells@redhat.com, sage@inktank.com, smfrench@gmail.com,
swhiteho@redhat.com, Trond.Myklebust@netapp.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
cluster-devel@redhat.com, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, piastryyy@gmail.com
Subject: [PATCH v1 01/11] cifs: use posix_unblock_lock instead of locks_delete_block
Date: Fri, 31 May 2013 23:07:24 -0400 [thread overview]
Message-ID: <1370056054-25449-2-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1370056054-25449-1-git-send-email-jlayton@redhat.com>
commit 66189be74 (CIFS: Fix VFS lock usage for oplocked files) exported
the locks_delete_block symbol. There's already an exported helper
function that provides this capability however, so make cifs use that
instead and turn locks_delete_block back into a static function.
Note that if fl->fl_next == NULL then this lock has already been through
locks_delete_block(), so we should be OK to ignore an ENOENT error here
and simply not retry the lock.
Cc: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/cifs/file.c | 2 +-
fs/locks.c | 3 +--
include/linux/fs.h | 5 -----
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 48b29d2..44a4f18 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -999,7 +999,7 @@ try_again:
rc = wait_event_interruptible(flock->fl_wait, !flock->fl_next);
if (!rc)
goto try_again;
- locks_delete_block(flock);
+ posix_unblock_lock(file, flock);
}
return rc;
}
diff --git a/fs/locks.c b/fs/locks.c
index cb424a4..7a02064 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -496,13 +496,12 @@ static void __locks_delete_block(struct file_lock *waiter)
/*
*/
-void locks_delete_block(struct file_lock *waiter)
+static void locks_delete_block(struct file_lock *waiter)
{
lock_flocks();
__locks_delete_block(waiter);
unlock_flocks();
}
-EXPORT_SYMBOL(locks_delete_block);
/* Insert waiter into blocker's block list.
* We use a circular list so that processes can be easily woken up in
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 43db02e..b9d7816 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1006,7 +1006,6 @@ extern int vfs_setlease(struct file *, long, struct file_lock **);
extern int lease_modify(struct file_lock **, int);
extern int lock_may_read(struct inode *, loff_t start, unsigned long count);
extern int lock_may_write(struct inode *, loff_t start, unsigned long count);
-extern void locks_delete_block(struct file_lock *waiter);
extern void lock_flocks(void);
extern void unlock_flocks(void);
#else /* !CONFIG_FILE_LOCKING */
@@ -1151,10 +1150,6 @@ static inline int lock_may_write(struct inode *inode, loff_t start,
return 1;
}
-static inline void locks_delete_block(struct file_lock *waiter)
-{
-}
-
static inline void lock_flocks(void)
{
}
--
1.7.1
next prev parent reply other threads:[~2013-06-01 3:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 3:07 [PATCH v1 00/11] locks: scalability improvements for file locking Jeff Layton
2013-06-01 3:07 ` Jeff Layton [this message]
[not found] ` <1370056054-25449-2-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-03 21:53 ` [PATCH v1 01/11] cifs: use posix_unblock_lock instead of locks_delete_block J. Bruce Fields
2013-06-01 3:07 ` [PATCH v1 02/11] locks: make generic_add_lease and generic_delete_lease static Jeff Layton
[not found] ` <1370056054-25449-3-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-03 21:53 ` J. Bruce Fields
2013-06-01 3:07 ` [PATCH v1 04/11] locks: make "added" in __posix_lock_file a bool Jeff Layton
2013-06-04 20:17 ` J. Bruce Fields
2013-06-01 3:07 ` [PATCH v1 05/11] locks: encapsulate the fl_link list handling Jeff Layton
2013-06-04 20:17 ` J. Bruce Fields
2013-06-01 3:07 ` [PATCH v1 07/11] locks: only pull entries off of blocked_list when they are really unblocked Jeff Layton
[not found] ` <1370056054-25449-8-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 21:58 ` J. Bruce Fields
[not found] ` <20130604215839.GD15594-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-06-05 11:38 ` Jeff Layton
[not found] ` <20130605073822.4d67c57c-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2013-06-05 12:24 ` J. Bruce Fields
2013-06-05 12:38 ` Jeff Layton
[not found] ` <20130605083859.72c855cd-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2013-06-05 12:59 ` J. Bruce Fields
2013-06-01 3:07 ` [PATCH v1 08/11] locks: convert fl_link to a hlist_node Jeff Layton
[not found] ` <1370056054-25449-9-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 21:59 ` J. Bruce Fields
2013-06-05 11:43 ` Jeff Layton
[not found] ` <20130605074309.051ff75f-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2013-06-05 12:46 ` J. Bruce Fields
[not found] ` <1370056054-25449-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-01 3:07 ` [PATCH v1 03/11] locks: comment cleanups and clarifications Jeff Layton
[not found] ` <1370056054-25449-4-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-03 22:00 ` J. Bruce Fields
[not found] ` <20130603220024.GF2109-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-06-04 11:09 ` Jeff Layton
2013-06-01 3:07 ` [PATCH v1 06/11] locks: convert to i_lock to protect i_flock list Jeff Layton
2013-06-04 21:22 ` J. Bruce Fields
[not found] ` <20130604212208.GC15594-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-06-05 0:46 ` Jeff Layton
2013-06-01 3:07 ` [PATCH v1 09/11] locks: turn the blocked_list into a hashtable Jeff Layton
2013-06-01 3:07 ` [PATCH v1 10/11] locks: add a new "lm_owner_key" lock operation Jeff Layton
2013-06-01 3:07 ` [PATCH v1 11/11] locks: give the blocked_hash its own spinlock Jeff Layton
[not found] ` <1370056054-25449-12-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 14:19 ` Stefan (metze) Metzmacher
2013-06-04 14:39 ` Jeff Layton
2013-06-04 14:46 ` Christoph Hellwig
[not found] ` <20130604144640.GA7730-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-06-04 14:53 ` J. Bruce Fields
2013-06-04 15:15 ` Jeff Layton
2013-06-04 14:56 ` Jeff Layton
2013-06-03 19:04 ` [PATCH v1 00/11] locks: scalability improvements for file locking Davidlohr Bueso
2013-06-03 21:31 ` J. Bruce Fields
2013-06-04 10:54 ` Jeff Layton
[not found] ` <20130604065417.46080a57-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-06-04 11:56 ` Jim Rees
[not found] ` <20130604115644.GA4180-63aXycvo3TyHXe+LvDLADg@public.gmane.org>
2013-06-04 12:15 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370056054-25449-2-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=piastryyy@gmail.com \
--cc=sage@inktank.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).