linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: nfsv4 mount with noexec
       [not found] ` <CAJ75kXa858MgWZ5A5dt+EswJyR4rJx1ke5Siv8hxds5FPJz_ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-06-02 20:56   ` Myklebust, Trond
       [not found]     ` <1370206557.46256.12.camel-5lNtUQgoD8Pfa3cDbr2K10B+6BGkLq7r@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Myklebust, Trond @ 2013-06-02 20:56 UTC (permalink / raw)
  To: William Dauchy
  Cc: Linux NFS mailing list,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Sat, 2013-06-01 at 13:33 +0200, William Dauchy wrote:
> Hello,
> 
> I've been testing a nfsv4 client based on a 3.8.13 kernel with the
> following additional patches:
> a3c3cac SUNRPC: Prevent an rpc_task wakeup race
> f448bad NFSv4: Fix a thinko in nfs4_try_open_cached
> eb54d43 NFS: Fix security flavor negotiation with legacy binary mounts
> 
> the mount options are:
> type nfs4
> rw,nosuid,nodev,noexec,noatime,nodiratime,vers=4.0,rsize=32768,wsize=32768,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,local_lock=none
> 
> Even with the noexec option, I'm still able to execute local binaries
> on the mounted file system.
> Am I wrong on something? I didn't had the issue on a 3.4.x

The mount level flags such as 'nosuid', 'nodev' and 'noexec' are
supposed to be enforced by the VFS, and not by the NFS code. The check
is supposedly done in fs/exec.c:open_exec() after the file has been
opened by the filesystem.

Does 'cat /proc/mounts' actually show the noexec option being applied to
the mountpoint by the kernel?

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: nfsv4 mount with noexec
       [not found]     ` <1370206557.46256.12.camel-5lNtUQgoD8Pfa3cDbr2K10B+6BGkLq7r@public.gmane.org>
@ 2013-06-02 23:05       ` William Dauchy
  0 siblings, 0 replies; 2+ messages in thread
From: William Dauchy @ 2013-06-02 23:05 UTC (permalink / raw)
  To: Myklebust, Trond
  Cc: Linux NFS mailing list,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Sun, Jun 2, 2013 at 10:56 PM, Myklebust, Trond
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org> wrote:
> The mount level flags such as 'nosuid', 'nodev' and 'noexec' are
> supposed to be enforced by the VFS, and not by the NFS code. The check
> is supposedly done in fs/exec.c:open_exec() after the file has been
> opened by the filesystem.
>
> Does 'cat /proc/mounts' actually show the noexec option being applied to
> the mountpoint by the kernel?

arg I mixed the original mount point and a binded mount point.

Sorry for the noise,

--
William
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-02 23:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJ75kXa858MgWZ5A5dt+EswJyR4rJx1ke5Siv8hxds5FPJz_ww@mail.gmail.com>
     [not found] ` <CAJ75kXa858MgWZ5A5dt+EswJyR4rJx1ke5Siv8hxds5FPJz_ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-02 20:56   ` nfsv4 mount with noexec Myklebust, Trond
     [not found]     ` <1370206557.46256.12.camel-5lNtUQgoD8Pfa3cDbr2K10B+6BGkLq7r@public.gmane.org>
2013-06-02 23:05       ` William Dauchy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).