From mboxrd@z Thu Jan 1 00:00:00 1970 From: zwu.kernel@gmail.com Subject: [PATCH v3 09/13] VFS hot tracking, procfs: add one proc interface Date: Fri, 21 Jun 2013 20:17:18 +0800 Message-ID: <1371817042-8556-10-git-send-email-zwu.kernel@gmail.com> References: <1371817042-8556-1-git-send-email-zwu.kernel@gmail.com> Cc: viro@zeniv.linux.org.uk, sekharan@us.ibm.com, linuxram@us.ibm.com, david@fromorbit.com, chris.mason@fusionio.com, jbacik@fusionio.com, Zhi Yong Wu To: linux-fsdevel@vger.kernel.org Return-path: Received: from e7.ny.us.ibm.com ([32.97.182.137]:50952 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161107Ab3FUMTc (ORCPT ); Fri, 21 Jun 2013 08:19:32 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Jun 2013 08:19:32 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 7EF656E803F for ; Fri, 21 Jun 2013 08:19:24 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5LCItew290358 for ; Fri, 21 Jun 2013 08:18:55 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5LCIr3t001620 for ; Fri, 21 Jun 2013 08:18:55 -0400 In-Reply-To: <1371817042-8556-1-git-send-email-zwu.kernel@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Zhi Yong Wu Add one proc interface hot-update-interval under the dir /proc/sys/fs/ in order to turn HOT_UPDATE_INTERVAL into be tunable. Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- fs/hot_tracking.c | 7 +++++-- fs/hot_tracking.h | 3 --- include/linux/hot_tracking.h | 3 +++ kernel/sysctl.c | 7 +++++++ 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/fs/hot_tracking.c b/fs/hot_tracking.c index aa1916d..0d265b9 100644 --- a/fs/hot_tracking.c +++ b/fs/hot_tracking.c @@ -23,6 +23,9 @@ static struct dentry *hot_debugfs_root; +int sysctl_hot_update_interval __read_mostly = 300; +EXPORT_SYMBOL_GPL(sysctl_hot_update_interval); + /* kmem_cache pointers for slab caches */ static struct kmem_cache *hot_inode_item_cachep __read_mostly; static struct kmem_cache *hot_range_item_cachep __read_mostly; @@ -605,7 +608,7 @@ static void hot_update_worker(struct work_struct *work) /* Instert next delayed work */ queue_delayed_work(root->update_wq, &root->update_work, - msecs_to_jiffies(HOT_UPDATE_INTERVAL * MSEC_PER_SEC)); + msecs_to_jiffies(sysctl_hot_update_interval * MSEC_PER_SEC)); } static void *hot_range_seq_start(struct seq_file *seq, loff_t *pos) @@ -1184,7 +1187,7 @@ static struct hot_info *hot_tree_init(struct super_block *sb) /* Initialize hot tracking wq and arm one delayed work */ INIT_DELAYED_WORK(&root->update_work, hot_update_worker); queue_delayed_work(root->update_wq, &root->update_work, - msecs_to_jiffies(HOT_UPDATE_INTERVAL * MSEC_PER_SEC)); + msecs_to_jiffies(sysctl_hot_update_interval * MSEC_PER_SEC)); /* Register a shrinker callback */ root->hot_shrink.shrink = hot_track_prune; diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h index fcc60ac..d1ab48b 100644 --- a/fs/hot_tracking.h +++ b/fs/hot_tracking.h @@ -15,9 +15,6 @@ #include #include -#define HOT_UPDATE_INTERVAL 150 -#define HOT_AGE_INTERVAL 300 - /* size of sub-file ranges */ #define RANGE_BITS 20 #define FREQ_POWER 4 diff --git a/include/linux/hot_tracking.h b/include/linux/hot_tracking.h index bd683c9..f5c5769 100644 --- a/include/linux/hot_tracking.h +++ b/include/linux/hot_tracking.h @@ -110,6 +110,9 @@ struct hot_info { atomic_t run_debugfs; }; +/* set how often to update temperatures (seconds) */ +extern int sysctl_hot_update_interval; + /* * Hot data tracking ioctls: * diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 9edcf45..1ba111d 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1616,6 +1616,13 @@ static struct ctl_table fs_table[] = { .proc_handler = &pipe_proc_fn, .extra1 = &pipe_min_size, }, + { + .procname = "hot-update-interval", + .data = &sysctl_hot_update_interval, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec, + }, { } }; -- 1.7.11.7