From: Jeff Layton <jlayton@redhat.com>
To: viro@zeniv.linux.org.uk, matthew@wil.cx, bfields@fieldses.org
Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
cluster-devel@redhat.com, sage@inktank.com,
samba-technical@lists.samba.org, Trond.Myklebust@netapp.com,
linux-kernel@vger.kernel.org, piastryyy@gmail.com,
linux-afs@lists.infradead.org, dhowells@redhat.com,
smfrench@gmail.com, linux-fsdevel@vger.kernel.org,
ceph-devel@vger.kernel.org, akpm@linux-foundation.org
Subject: [PATCH v4 02/14] cifs: use posix_unblock_lock instead of locks_delete_block
Date: Fri, 21 Jun 2013 08:58:10 -0400 [thread overview]
Message-ID: <1371819502-26363-3-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1371819502-26363-1-git-send-email-jlayton@redhat.com>
commit 66189be74 (CIFS: Fix VFS lock usage for oplocked files) exported
the locks_delete_block symbol. There's already an exported helper
function that provides this capability however, so make cifs use that
instead and turn locks_delete_block back into a static function.
Note that if fl->fl_next == NULL then this lock has already been through
locks_delete_block(), so we should be OK to ignore an ENOENT error here
and simply not retry the lock.
Cc: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: J. Bruce Fields <bfields@fieldses.org>
---
fs/cifs/file.c | 2 +-
fs/locks.c | 3 +--
include/linux/fs.h | 5 -----
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 48b29d2..1686e40 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -999,7 +999,7 @@ try_again:
rc = wait_event_interruptible(flock->fl_wait, !flock->fl_next);
if (!rc)
goto try_again;
- locks_delete_block(flock);
+ posix_unblock_lock(flock);
}
return rc;
}
diff --git a/fs/locks.c b/fs/locks.c
index 72fb2b7..d732e22 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -496,13 +496,12 @@ static void __locks_delete_block(struct file_lock *waiter)
/*
*/
-void locks_delete_block(struct file_lock *waiter)
+static void locks_delete_block(struct file_lock *waiter)
{
lock_flocks();
__locks_delete_block(waiter);
unlock_flocks();
}
-EXPORT_SYMBOL(locks_delete_block);
/* Insert waiter into blocker's block list.
* We use a circular list so that processes can be easily woken up in
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 9f160c6..cabc08a 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1006,7 +1006,6 @@ extern int vfs_setlease(struct file *, long, struct file_lock **);
extern int lease_modify(struct file_lock **, int);
extern int lock_may_read(struct inode *, loff_t start, unsigned long count);
extern int lock_may_write(struct inode *, loff_t start, unsigned long count);
-extern void locks_delete_block(struct file_lock *waiter);
extern void lock_flocks(void);
extern void unlock_flocks(void);
#else /* !CONFIG_FILE_LOCKING */
@@ -1150,10 +1149,6 @@ static inline int lock_may_write(struct inode *inode, loff_t start,
return 1;
}
-static inline void locks_delete_block(struct file_lock *waiter)
-{
-}
-
static inline void lock_flocks(void)
{
}
--
1.7.1
next prev parent reply other threads:[~2013-06-21 12:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 12:58 [PATCH v4 00/14] locks: scalability improvements for file locking Jeff Layton
2013-06-21 12:58 ` [PATCH v4 01/14] locks: drop the unused filp argument to posix_unblock_lock Jeff Layton
2013-06-21 12:58 ` Jeff Layton [this message]
2013-06-21 12:58 ` [PATCH v4 03/14] locks: make generic_add_lease and generic_delete_lease static Jeff Layton
2013-06-21 12:58 ` [PATCH v4 04/14] locks: comment cleanups and clarifications Jeff Layton
2013-06-21 12:58 ` [PATCH v4 05/14] locks: make "added" in __posix_lock_file a bool Jeff Layton
2013-06-21 12:58 ` [PATCH v4 06/14] locks: encapsulate the fl_link list handling Jeff Layton
[not found] ` <1371819502-26363-7-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-25 1:37 ` Stephen Rothwell
[not found] ` <20130625113704.89a686a55dcec684e5e99434-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2013-06-25 10:32 ` Jeff Layton
2013-06-21 12:58 ` [PATCH v4 07/14] locks: protect most of the file_lock handling with i_lock Jeff Layton
2013-06-21 12:58 ` [PATCH v4 08/14] locks: avoid taking global lock if possible when waking up blocked waiters Jeff Layton
2013-06-21 12:58 ` [PATCH v4 09/14] locks: convert fl_link to a hlist_node Jeff Layton
[not found] ` <1371819502-26363-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-21 12:58 ` [PATCH v4 10/14] locks: turn the blocked_list into a hashtable Jeff Layton
2013-06-21 12:58 ` [PATCH v4 11/14] locks: add a new "lm_owner_key" lock operation Jeff Layton
2013-06-21 12:58 ` [PATCH v4 12/14] locks: give the blocked_hash its own spinlock Jeff Layton
2013-06-21 12:58 ` [PATCH v4 13/14] seq_file: add seq_list_*_percpu helpers Jeff Layton
2013-06-21 12:58 ` [PATCH v4 14/14] locks: move file_lock_list to a set of percpu hlist_heads and convert file_lock_lock to an lglock Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371819502-26363-3-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=piastryyy@gmail.com \
--cc=sage@inktank.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).