From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: linux-nilfs@vger.kernel.org, bryce@gibson-consulting.com.au,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] nilfs2: correct logic of translation virtual blocks number into physical ones
Date: Wed, 03 Jul 2013 13:24:55 +0400 [thread overview]
Message-ID: <1372843495.2230.8.camel@slavad-ubuntu> (raw)
In-Reply-To: <20130702.010238.65450534.konishi.ryusuke@lab.ntt.co.jp>
Hi Ryusuke,
On Tue, 2013-07-02 at 01:02 +0900, Ryusuke Konishi wrote:
[snip]
> Vyacheslav, this patch breaks snapshot mounts because past blocks
> deleted from the current file system have an end checkpoint number
> smaller than the current checkpoint number.
>
Yes, you are right. It needs to rework this patch.
I will be on vacation during next two weeks. And then, after vacation, I
continue to work with patches and fixes for NILFS2. I will keep silence
during my vacation time.
Thank you for the remark.
> Also, the title of this patch looks wrong. You are trying to insert a
> sanity check in the translation logic. It doesn't correct translation
> logic itself, nor removes the cause of reported problem.
>
> I think the title of this patch should be "nilfs2: insert sanity check
> in translation logic of ..." or so.
Ok. I agree.
With the best regards,
Vyacheslav Dubeyko.
>
> Regards,
> Ryusuke Konishi
>
prev parent reply other threads:[~2013-07-03 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 10:34 [PATCH] nilfs2: correct logic of translation virtual blocks number into physical ones Vyacheslav Dubeyko
2013-07-01 16:02 ` Ryusuke Konishi
2013-07-03 9:24 ` Vyacheslav Dubeyko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372843495.2230.8.camel@slavad-ubuntu \
--to=slava@dubeyko.com \
--cc=akpm@linux-foundation.org \
--cc=bryce@gibson-consulting.com.au \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).