linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper
@ 2013-07-05 14:48 Waiman Long
  2013-07-06 10:45 ` Ryusuke Konishi
  0 siblings, 1 reply; 2+ messages in thread
From: Waiman Long @ 2013-07-05 14:48 UTC (permalink / raw)
  To: Alexander Viro, Jeff Layton, Miklos Szeredi, Ingo Molnar,
	Thomas Gleixner
  Cc: KONISHI Ryusuke, linux-nilfs, Waiman Long, linux-fsdevel,
	linux-kernel, Peter Zijlstra, Steven Rostedt, Linus Torvalds,
	Benjamin Herrenschmidt, Andi Kleen, Chandramouleeswaran, Aswin,
	Norton, Scott J

Because of the d_count change made in dcache.h, all readonly references
to d_count have to be changed to use the new d_count() helper as they
shouldn't access its value directly.  There is no change in logic
and everything should just work.

Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
 fs/nilfs2/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index c7d1f9f..bd9d1f2 100644
--- a/fs/nilfs2/super.c
+++ b/fs/nilfs2/super.c
@@ -973,7 +973,7 @@ static int nilfs_attach_snapshot(struct super_block *s, __u64 cno,
 
 static int nilfs_tree_was_touched(struct dentry *root_dentry)
 {
-	return root_dentry->d_count > 1;
+	return d_count(root_dentry) > 1;
 }
 
 /**
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper
  2013-07-05 14:48 [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper Waiman Long
@ 2013-07-06 10:45 ` Ryusuke Konishi
  0 siblings, 0 replies; 2+ messages in thread
From: Ryusuke Konishi @ 2013-07-06 10:45 UTC (permalink / raw)
  To: Waiman Long
  Cc: Alexander Viro, Jeff Layton, Miklos Szeredi, Ingo Molnar,
	Thomas Gleixner, linux-nilfs, linux-fsdevel, linux-kernel,
	Peter Zijlstra, Steven Rostedt, Linus Torvalds,
	Benjamin Herrenschmidt, Andi Kleen, Chandramouleeswaran, Aswin,
	Norton, Scott J

On Fri,  5 Jul 2013 10:48:29 -0400, Waiman Long <Waiman.Long@hp.com> wrote:
> Because of the d_count change made in dcache.h, all readonly references
> to d_count have to be changed to use the new d_count() helper as they
> shouldn't access its value directly.  There is no change in logic
> and everything should just work.
> 
> Signed-off-by: Waiman Long <Waiman.Long@hp.com>

Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>


Thanks,
Ryusuke Konishi

> ---
>  fs/nilfs2/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index c7d1f9f..bd9d1f2 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -973,7 +973,7 @@ static int nilfs_attach_snapshot(struct super_block *s, __u64 cno,
>  
>  static int nilfs_tree_was_touched(struct dentry *root_dentry)
>  {
> -	return root_dentry->d_count > 1;
> +	return d_count(root_dentry) > 1;
>  }
>  
>  /**
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-06 10:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-05 14:48 [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper Waiman Long
2013-07-06 10:45 ` Ryusuke Konishi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).