From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] f2fs: check the search bound earlier in dir.c/room_for_filename
Date: Mon, 15 Jul 2013 09:00:13 +0900 [thread overview]
Message-ID: <1373846413.26443.9.camel@kjgkr> (raw)
In-Reply-To: <51D9324A.3010305@gmail.com>
Hi,
2013-07-07 (일), 17:18 +0800, Wang Sheng-Hui:
> On 2013年07月07日 17:10, Wang Sheng-Hui wrote:
> > Check the bound earlier than computing the next search start pos.
> >
> > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> > ---
> > fs/f2fs/dir.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> > index 9d1cd42..83a3549 100644
> > --- a/fs/f2fs/dir.c
> > +++ b/fs/f2fs/dir.c
> > @@ -406,13 +406,17 @@ next:
> > zero_end = find_next_bit_le(&dentry_blk->dentry_bitmap,
> > NR_DENTRY_IN_BLOCK,
> > zero_start);
> > + if (zero_end >= NR_DENTRY_IN_BLOCK)
> > + zero_end = NR_DENTRY_IN_BLOCK;
> > +
This assignment is needless, since find_next_bit_le returns less or
equal than NR_DENTRY_IN_BLOCK all the time.
> > if (zero_end - zero_start >= slots)
> > return zero_start;
> >
> > + if (zero_end >= NR_DENTRY_IN_BLOCK)
> > + return NR_DENTRY_IN_BLOCK;
> > +
So we don't need to do like this.
Thanks,
> > bit_start = zero_end + 1;
> >
> > - if (zero_end + 1 >= NR_DENTRY_IN_BLOCK)
> > - return NR_DENTRY_IN_BLOCK;
> > goto next;
> > }
> >
>
> Sorry, paste the wrong one. Please check the following patch.
>
> Thanks,
>
>
> From cda0fe2ebdd2d5afe2324c567444fc6329f98d6d Mon Sep 17 00:00:00 2001
> From: Wang Sheng-Hui <shhuiw@gmail.com>
> Date: Sun, 7 Jul 2013 17:15:54 +0800
> Subject: [PATCH] f2fs: check the search bound earlier in dir.c/room_for_filename
>
> Check the bound earlier than computing the next search start pos.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> fs/f2fs/dir.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 9d1cd42..cc405c5 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -406,12 +406,14 @@ next:
> zero_end = find_next_bit_le(&dentry_blk->dentry_bitmap,
> NR_DENTRY_IN_BLOCK,
> zero_start);
> + if (zero_end >= NR_DENTRY_IN_BLOCK)
> + zero_end = NR_DENTRY_IN_BLOCK;
> +
> if (zero_end - zero_start >= slots)
> return zero_start;
>
> bit_start = zero_end + 1;
> -
> - if (zero_end + 1 >= NR_DENTRY_IN_BLOCK)
> + if (bit_start >= NR_DENTRY_IN_BLOCK)
> return NR_DENTRY_IN_BLOCK;
> goto next;
> }
--
Jaegeuk Kim
Samsung
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-15 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 9:10 [PATCH] f2fs: check the search bound earlier in dir.c/room_for_filename Wang Sheng-Hui
2013-07-07 9:18 ` Wang Sheng-Hui
2013-07-15 0:00 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373846413.26443.9.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).