From: Joe Perches <joe@perches.com>
To: Jeremy Allison <jra@samba.org>
Cc: Steve French <smfrench@gmail.com>,
Jeff Layton <jlayton@samba.org>,
linux-cifs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Recvfile patch used for Samba.
Date: Mon, 22 Jul 2013 16:26:20 -0700 [thread overview]
Message-ID: <1374535580.2061.85.camel@joe-AO722> (raw)
In-Reply-To: <20130722215738.GB20647@samba2>
On Mon, 2013-07-22 at 14:57 -0700, Jeremy Allison wrote:
> Here is a patch that Samba vendors have been using
> to implement recvfile (copy directly from socket
> to file). It can improve write performance on boxes
> by a significant amount (10% or more).
>
> I'm not qualified to evaluate this code,
Nor I really. This doesn't apply to current btw.
Single comment: (just on a brief look)
do_splice_from_socket with 64bit compilation appears
to have a pretty large (~1500 byte) stack frame which
doesn't seem very nice. maybe a malloc/free instead
of stack for
struct recvfile_ctl_blk rv_cb[MAX_PAGES_PER_RECVFILE];
struct kvec iov[MAX_PAGES_PER_RECVFILE];
next prev parent reply other threads:[~2013-07-22 23:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:57 Recvfile patch used for Samba Jeremy Allison
2013-07-22 23:26 ` Joe Perches [this message]
2013-07-23 7:10 ` Dave Chinner
2013-07-23 13:31 ` Jeff Layton
2013-07-23 21:58 ` Jeremy Allison
2013-07-24 2:47 ` Dave Chinner
2013-07-25 8:17 ` Steven Whitehouse
2013-07-26 4:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374535580.2061.85.camel@joe-AO722 \
--to=joe@perches.com \
--cc=jlayton@samba.org \
--cc=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).