From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: [PATCH 2/3] locks: remove "inline" qualifier from fl_link manipulation functions Date: Wed, 14 Aug 2013 08:25:48 -0400 Message-ID: <1376483149-7633-3-git-send-email-jlayton@redhat.com> References: <1376483149-7633-1-git-send-email-jlayton@redhat.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox To: Al Viro Return-path: Received: from mail-vb0-f49.google.com ([209.85.212.49]:37260 "EHLO mail-vb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759791Ab3HNMZ5 (ORCPT ); Wed, 14 Aug 2013 08:25:57 -0400 Received: by mail-vb0-f49.google.com with SMTP id w16so7549467vbb.36 for ; Wed, 14 Aug 2013 05:25:57 -0700 (PDT) In-Reply-To: <1376483149-7633-1-git-send-email-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: It's best to let the compiler decide that. Reported-by: Stephen Rothwell Signed-off-by: Jeff Layton --- fs/locks.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 9f28359..b1e5bfe 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -511,8 +511,7 @@ static int posix_same_owner(struct file_lock *fl1, struct file_lock *fl2) } /* Must be called with the i_lock held! */ -static inline void -locks_insert_global_locks(struct file_lock *fl) +static void locks_insert_global_locks(struct file_lock *fl) { lg_local_lock(&file_lock_lglock); fl->fl_link_cpu = smp_processor_id(); @@ -521,8 +520,7 @@ locks_insert_global_locks(struct file_lock *fl) } /* Must be called with the i_lock held! */ -static inline void -locks_delete_global_locks(struct file_lock *fl) +static void locks_delete_global_locks(struct file_lock *fl) { /* * Avoid taking lock if already unhashed. This is safe since this check @@ -544,14 +542,12 @@ posix_owner_key(struct file_lock *fl) return (unsigned long)fl->fl_owner; } -static inline void -locks_insert_global_blocked(struct file_lock *waiter) +static void locks_insert_global_blocked(struct file_lock *waiter) { hash_add(blocked_hash, &waiter->fl_link, posix_owner_key(waiter)); } -static inline void -locks_delete_global_blocked(struct file_lock *waiter) +static void locks_delete_global_blocked(struct file_lock *waiter) { hash_del(&waiter->fl_link); } -- 1.8.3.1