From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] vfio-pci: PCI hot reset interface
Date: Tue, 20 Aug 2013 08:44:40 +1000 [thread overview]
Message-ID: <1376952280.25016.87.camel@pasglop> (raw)
In-Reply-To: <1376943632.2657.25.camel@ul30vt.home>
On Mon, 2013-08-19 at 14:20 -0600, Alex Williamson wrote:
> I try to handle the slot as opaque, only caring that the slot pointer
> matches, so I think our implementation is ok... so long as we only get
> one driver claiming to manage a slot, but that's not a vfio problem ;)
> Thanks,
By why bother with slots ? Why do you even think about slots in that
context ? slots are a badly defined thing in our current PCI stack,
pretty much intricated with hotplug. I don't see why the reset semantics
would be tied to slots at all.
The only case where it *might* make some sense (and even then ...) is if
you want to start exposing slot power control and PERST but that would
imply a pile of platform specific gunk anyway.
Ben.
next prev parent reply other threads:[~2013-08-19 22:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130814200845.21923.64284.stgit@bling.home>
2013-08-14 22:42 ` [PATCH] vfio-pci: PCI hot reset interface Bjorn Helgaas
2013-08-14 23:06 ` Alex Williamson
2013-08-19 18:41 ` Alex Williamson
2013-08-19 20:02 ` Bjorn Helgaas
2013-08-19 20:20 ` Alex Williamson
2013-08-19 22:44 ` Benjamin Herrenschmidt [this message]
2013-08-19 23:02 ` Alex Williamson
2013-08-19 22:42 ` Benjamin Herrenschmidt
2013-08-19 22:59 ` Alex Williamson
2013-08-19 23:52 ` Benjamin Herrenschmidt
2013-08-20 3:18 ` Al Viro
2013-08-20 3:53 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376952280.25016.87.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).