From: "J. Bruce Fields" <bfields@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 3/3] dcache: don't clear DCACHE_DISCONNECTED too early
Date: Fri, 6 Sep 2013 11:43:50 -0400 [thread overview]
Message-ID: <1378482230-16312-3-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1378482230-16312-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
DCACHE_DISCONNECTED should not be cleared until we're sure the dentry is
connected all the way up to the root of the filesystem. It *shouldn't*
be cleared as soon as the dentry is connected to a parent. That will
cause bugs at least on exportable filesystems.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/dcache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index ec66780..69f1ba0 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2396,7 +2396,6 @@ static void __d_materialise_dentry(struct dentry *dentry, struct dentry *anon)
spin_unlock(&dentry->d_lock);
/* anon->d_lock still locked, returns locked */
- anon->d_flags &= ~DCACHE_DISCONNECTED;
}
/**
--
1.7.9.5
next prev parent reply other threads:[~2013-09-06 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 15:43 [PATCH 1/3] dcache: use IS_ROOT to decide where dentry is hashed J. Bruce Fields
2013-09-06 15:43 ` [PATCH 2/3] dcache: Don't set DISCONNECTED on "pseudo filesystem" dentries J. Bruce Fields
2013-09-06 17:03 ` Christoph Hellwig
[not found] ` <20130906170339.GB6460-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-09-06 19:29 ` J. Bruce Fields
2013-09-06 15:43 ` J. Bruce Fields [this message]
[not found] ` <1378482230-16312-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-06 17:00 ` [PATCH 1/3] dcache: use IS_ROOT to decide where dentry is hashed Christoph Hellwig
[not found] ` <20130906170044.GA6460-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-09-06 19:03 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378482230-16312-3-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).