linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	jlayton@redhat.com, Dave Chinner <david@fromorbit.com>,
	"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 02/13] vfs: don't use PARENT/CHILD lock classes for non-directories
Date: Thu, 19 Sep 2013 16:50:26 -0400	[thread overview]
Message-ID: <1379623837-30798-3-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1379623837-30798-1-git-send-email-bfields@redhat.com>

From: "J. Bruce Fields" <bfields@redhat.com>

Reserve I_MUTEX_PARENT and I_MUTEX_CHILD for locking of actual
directories.

(Also I_MUTEX_QUOTA isn't really a meaningful name for this locking
class any more; fixed in a later patch.)

Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/inode.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index 9271c48..04d0e2d 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -959,16 +959,16 @@ void lock_two_nondirectories(struct inode *inode1, struct inode *inode2)
 {
 	WARN_ON_ONCE(S_ISDIR(inode1->i_mode));
 	if (inode1 == inode2 || !inode2) {
-		mutex_lock_nested(&inode1->i_mutex, I_MUTEX_PARENT);
+		mutex_lock(&inode1->i_mutex);
 		return;
 	}
 	WARN_ON_ONCE(S_ISDIR(inode2->i_mode));
 	if (inode1 < inode2) {
-		mutex_lock_nested(&inode1->i_mutex, I_MUTEX_PARENT);
-		mutex_lock_nested(&inode2->i_mutex, I_MUTEX_CHILD);
+		mutex_lock(&inode1->i_mutex);
+		mutex_lock_nested(&inode2->i_mutex, I_MUTEX_QUOTA);
 	} else {
-		mutex_lock_nested(&inode2->i_mutex, I_MUTEX_PARENT);
-		mutex_lock_nested(&inode1->i_mutex, I_MUTEX_CHILD);
+		mutex_lock(&inode2->i_mutex);
+		mutex_lock_nested(&inode1->i_mutex, I_MUTEX_QUOTA);
 	}
 }
 EXPORT_SYMBOL(lock_two_nondirectories);
-- 
1.7.9.5


  parent reply	other threads:[~2013-09-19 20:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 20:50 [PATCH 00/13] Implement NFSv4 delegations, take 12 J. Bruce Fields
2013-09-19 20:50 ` [PATCH 01/13] vfs: pull ext4's double-i_mutex-locking into common code J. Bruce Fields
2013-09-19 20:50 ` J. Bruce Fields [this message]
2013-09-19 20:50 ` [PATCH 03/13] vfs: rename I_MUTEX_QUOTA now that it's not used for quotas J. Bruce Fields
2013-09-19 20:50 ` [PATCH 04/13] vfs: take i_mutex on renamed file J. Bruce Fields
     [not found] ` <1379623837-30798-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-19 20:50   ` [PATCH 05/13] locks: introduce new FL_DELEG lock flag J. Bruce Fields
2013-09-19 20:50   ` [PATCH 06/13] locks: implement delegations J. Bruce Fields
2013-09-19 20:50   ` [PATCH 08/13] locks: break delegations on unlink J. Bruce Fields
2013-09-19 20:50   ` [PATCH 12/13] locks: break delegations on any attribute modification J. Bruce Fields
2013-10-02 13:54   ` [PATCH 00/13] Implement NFSv4 delegations, take 12 J. Bruce Fields
     [not found]     ` <20131002135423.GA14808-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-10-02 20:16       ` J. Bruce Fields
2013-10-03 19:41         ` J. Bruce Fields
2013-10-07 15:20           ` J. Bruce Fields
2013-09-19 20:50 ` [PATCH 07/13] namei: minor vfs_unlink cleanup J. Bruce Fields
2013-09-19 20:50 ` [PATCH 09/13] locks: helper functions for delegation breaking J. Bruce Fields
2013-09-19 20:50 ` [PATCH 10/13] locks: break delegations on rename J. Bruce Fields
2013-09-19 20:50 ` [PATCH 11/13] locks: break delegations on link J. Bruce Fields
2013-09-19 20:50 ` [PATCH 13/13] locks: close potential race between setlease and open J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2013-09-11 20:03 [PATCH 00/13] Implement NFSv4 delegations, take 11 J. Bruce Fields
     [not found] ` <1378929799-1110-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-11 20:03   ` [PATCH 02/13] vfs: don't use PARENT/CHILD lock classes for non-directories J. Bruce Fields
     [not found]     ` <1378929799-1110-3-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-12  3:14       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379623837-30798-3-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=david@fromorbit.com \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).