From: Amit Pundir <amit.pundir@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
"Arve Hjønnevåg" <arve@android.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>
Cc: John Stultz <john.stultz@linaro.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Android Kernel Team <kernel-team@android.com>
Subject: [PATCH v3] epoll: drop EPOLLWAKEUP if PM_SLEEP is disabled
Date: Fri, 15 Nov 2013 12:56:31 +0530 [thread overview]
Message-ID: <1384500391-20513-1-git-send-email-amit.pundir@linaro.org> (raw)
Drop EPOLLWAKEUP from epoll events mask if CONFIG_PM_SLEEP is disabled.
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
Changes in v3:
Renamed ep_epollwakeup_check() to ep_take_care_of_epollwakeup().
Didn't update ep_create_wakeup_source() to return -ENOSYS if PM_SLEEP is unset.
---
fs/eventpoll.c | 3 +--
include/uapi/linux/eventpoll.h | 13 ++++++++++++-
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 473e09d..dbf382b 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1820,8 +1820,7 @@ SYSCALL_DEFINE4(epoll_ctl, int, epfd, int, op, int, fd,
goto error_tgt_fput;
/* Check if EPOLLWAKEUP is allowed */
- if ((epds.events & EPOLLWAKEUP) && !capable(CAP_BLOCK_SUSPEND))
- epds.events &= ~EPOLLWAKEUP;
+ ep_take_care_of_epollwakeup(&epds);
/*
* We have to check that the file structure underneath the file descriptor
diff --git a/include/uapi/linux/eventpoll.h b/include/uapi/linux/eventpoll.h
index 2c267bc..bc81fb2 100644
--- a/include/uapi/linux/eventpoll.h
+++ b/include/uapi/linux/eventpoll.h
@@ -61,5 +61,16 @@ struct epoll_event {
__u64 data;
} EPOLL_PACKED;
-
+#ifdef CONFIG_PM_SLEEP
+static inline void ep_take_care_of_epollwakeup(struct epoll_event *epev)
+{
+ if ((epev->events & EPOLLWAKEUP) && !capable(CAP_BLOCK_SUSPEND))
+ epev->events &= ~EPOLLWAKEUP;
+}
+#else
+static inline void ep_take_care_of_epollwakeup(struct epoll_event *epev)
+{
+ epev->events &= ~EPOLLWAKEUP;
+}
+#endif
#endif /* _UAPI_LINUX_EVENTPOLL_H */
--
1.7.10.4
next reply other threads:[~2013-11-15 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 7:26 Amit Pundir [this message]
2013-11-15 15:10 ` [PATCH v3] epoll: drop EPOLLWAKEUP if PM_SLEEP is disabled Rafael J. Wysocki
2013-11-15 18:53 ` John Stultz
2013-11-15 22:40 ` Rafael J. Wysocki
2013-11-15 22:35 ` John Stultz
2013-11-15 23:53 ` Rafael J. Wysocki
2013-11-25 19:38 ` John Stultz
2013-11-25 21:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384500391-20513-1-git-send-email-amit.pundir@linaro.org \
--to=amit.pundir@linaro.org \
--cc=arve@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).