From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH 2/2] aio: nullify aio->ring_pages after freeing it Date: Tue, 19 Nov 2013 17:33:03 -0500 Message-ID: <1384900383-22009-2-git-send-email-sasha.levin@oracle.com> References: <1384900383-22009-1-git-send-email-sasha.levin@oracle.com> Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin To: bcrl@kvack.org, viro@zeniv.linux.org.uk Return-path: In-Reply-To: <1384900383-22009-1-git-send-email-sasha.levin@oracle.com> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org After freeing ring_pages we leave it as is causing a dangling pointer. This has already caused an issue so to help catching any issues in the future NULL it out. Signed-off-by: Sasha Levin --- fs/aio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index 8b387a1..d6e8467 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -251,8 +251,10 @@ static void aio_free_ring(struct kioctx *ctx) put_aio_ring_file(ctx); - if (ctx->ring_pages && ctx->ring_pages != ctx->internal_pages) + if (ctx->ring_pages && ctx->ring_pages != ctx->internal_pages) { kfree(ctx->ring_pages); + ctx->ring_pages = NULL; + } } static int aio_ring_mmap(struct file *file, struct vm_area_struct *vma) -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org