Re: [PATCH] nilfs2: rework error message subsystem

[Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>]

On Tue, 2013-12-03 at 16:29 -0800, Andrew Morton wrote:

[snip]
> 
> It converts every printk in nilfs2 into pr_foo_ratelimited (and bloats
> nilfs2.ko by 5k in the process).  Isn't this rather overkill?
> 

I have converted not every printk() in nilfs2 but I agree that printk()
was changed in many places by ratelimited version. So, yes, it can be
not very good idea. But such replacement was made for code that can emit
really many count of practically identical error messages. And there are
situation of sophisticated issues in nilfs2 when huge amount of error
messages simply hide an important information about the issue. As a
result, my goal was to reduce amount of repeatable error messages.

So, what could you recommend as possible and proper solution?

Moreover, I cleaned up error messages subsystem of nilfs2 by change of
printk on pr_foo version and by joining error strings that it was split.
I believe that it makes sense. Of course, it is possible to leave nilfs2
error subsystem untouched. But from my point of view, there is the issue
of hiding important information about an issue's reason by huge amount
of repeatable error messages.

Thanks,
Vyacheslav Dubeyko.


--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html