From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Shishkin Subject: [PATCH] coredump: fix dump_align() helper Date: Wed, 11 Dec 2013 14:00:33 +0200 Message-ID: <1386763233-21096-1-git-send-email-alexander.shishkin@linux.intel.com> Cc: linux-fsdevel@vger.kernel.org, Alexander Shishkin To: Alexander Viro Return-path: Received: from mga11.intel.com ([192.55.52.93]:47601 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084Ab3LKMBK (ORCPT ); Wed, 11 Dec 2013 07:01:10 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The recent rework that introduced dump_emit() and dump_align() breaks existing core dump logic, which relies on these functions returning non zero when everything is fine, but right now dump_align() returns 0 if the current offset is already aligned on a given boundary. Signed-off-by: Alexander Shishkin --- fs/coredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coredump.c b/fs/coredump.c index 62406b6..0be8c01 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -734,6 +734,6 @@ int dump_align(struct coredump_params *cprm, int align) unsigned mod = cprm->written & (align - 1); if (align & (align - 1)) return -EINVAL; - return mod ? dump_skip(cprm, align - mod) : 0; + return mod ? dump_skip(cprm, align - mod) : 1; } EXPORT_SYMBOL(dump_align); -- 1.8.5.1