linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: nfs-ganesha-devel@lists.sourceforge.net,
	samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 11/13] locks: show private lock types in /proc/locks
Date: Thu, 19 Dec 2013 08:34:23 -0500	[thread overview]
Message-ID: <1387460065-28269-12-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1387460065-28269-1-git-send-email-jlayton@redhat.com>

In a later patch, we'll be adding a new type of lock that's owned by
the struct file instead of the files_struct. Those sorts of locks
will be flagged with a new IS_FILE_PVT flag.

Show "private" locks in /proc/locks with a 'P' suffix. This does mean
that we need to widen the column by one character.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/locks.c         | 9 ++++++---
 include/linux/fs.h | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/fs/locks.c b/fs/locks.c
index a217c2c..995583b 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -135,6 +135,7 @@
 #define IS_POSIX(fl)	(fl->fl_flags & FL_POSIX)
 #define IS_FLOCK(fl)	(fl->fl_flags & FL_FLOCK)
 #define IS_LEASE(fl)	(fl->fl_flags & (FL_LEASE|FL_DELEG))
+#define IS_FILE_PVT(fl)	(fl->fl_flags & FL_FILE_PVT)
 
 static bool lease_breaking(struct file_lock *fl)
 {
@@ -2336,13 +2337,15 @@ static void lock_get_status(struct seq_file *f, struct file_lock *fl,
 		seq_printf(f, "UNKNOWN UNKNOWN  ");
 	}
 	if (fl->fl_type & LOCK_MAND) {
-		seq_printf(f, "%s ",
+		seq_printf(f, "%s  ",
 			       (fl->fl_type & LOCK_READ)
 			       ? (fl->fl_type & LOCK_WRITE) ? "RW   " : "READ "
 			       : (fl->fl_type & LOCK_WRITE) ? "WRITE" : "NONE ");
+	} else if (IS_FILE_PVT(fl)) {
+		seq_printf(f, "%s ", fl->fl_type == F_WRLCK ?  "WRITEP" : "READP ");
 	} else {
-		seq_printf(f, "%s ",
-			       (lease_breaking(fl))
+		seq_printf(f, "%s  ",
+			       lease_breaking(fl)
 			       ? (fl->fl_type == F_UNLCK) ? "UNLCK" : "READ "
 			       : (fl->fl_type == F_WRLCK) ? "WRITE" : "READ ");
 	}
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 51974e0..639a3b7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -888,6 +888,7 @@ static inline int file_check_writeable(struct file *filp)
 #define FL_SLEEP	128	/* A blocking lock */
 #define FL_DOWNGRADE_PENDING	256 /* Lease is being downgraded */
 #define FL_UNLOCK_PENDING	512 /* Lease is being broken */
+#define FL_FILE_PVT	1024	/* lock is private to the file */
 
 /*
  * Special return value from posix_lock_file() and vfs_lock_file() for
-- 
1.8.4.2

  parent reply	other threads:[~2013-12-19 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 13:34 [PATCH v4 00/13] locks: implement "filp-private" (aka UNPOSIX) locks Jeff Layton
2013-12-19 13:34 ` [PATCH v4 01/13] locks: close potential race between setlease and open Jeff Layton
2013-12-19 13:34 ` [PATCH v4 02/13] locks: clean up comment typo Jeff Layton
2013-12-19 13:34 ` [PATCH v4 03/13] locks: remove "inline" qualifier from fl_link manipulation functions Jeff Layton
2013-12-19 13:34 ` [PATCH v4 04/13] locks: add __acquires and __releases annotations to locks_start and locks_stop Jeff Layton
2013-12-19 13:34 ` [PATCH v4 05/13] locks: eliminate BUG() call when there's an unexpected lock on file close Jeff Layton
2013-12-19 13:34 ` [PATCH v4 06/13] locks: consolidate common code in the flock_to_posix_lock routines Jeff Layton
2013-12-19 13:34 ` [PATCH v4 07/13] locks: simplify overflow checking Jeff Layton
2013-12-19 13:34 ` [PATCH v4 08/13] locks: consolidate checks for compatible filp->f_mode values in setlk handlers Jeff Layton
2013-12-19 13:34 ` [PATCH v4 09/13] locks: don't reference original flock struct in F_GETLK handlers Jeff Layton
2013-12-19 13:34 ` [PATCH v4 10/13] locks: rename locks_remove_flock to locks_remove_file Jeff Layton
2013-12-19 13:34 ` Jeff Layton [this message]
2013-12-19 13:34 ` [PATCH v4 12/13] locks: report l_pid as -1 for FL_FILE_PVT locks Jeff Layton
2013-12-19 13:34 ` [PATCH v4 13/13] locks: add new "private" lock type that is owned by the filp Jeff Layton
2013-12-19 13:52 ` [PATCH v4 00/13] locks: implement "filp-private" (aka UNPOSIX) locks Scott Lovenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387460065-28269-12-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfs-ganesha-devel@lists.sourceforge.net \
    --cc=samba-technical@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).