From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: Re: [PATCH 21/21] hfsplus: remove can_set_xattr
Date: Thu, 26 Dec 2013 14:59:12 +0400
Message-ID: <1388055552.4168.96.camel@slavad-ubuntu>
References: <20131220131635.650823732@bombadil.infradead.org>
	 <20131220132524.900291394@bombadil.infradead.org>
	 <636E01BC-12FD-452B-8B1C-320B6EADAEFD@dubeyko.com>
	 <20131222192818.GA32565@infradead.org>
	 <1387780809.3991.21.camel@slavad-ubuntu>
	 <20131223143706.GA8235@infradead.org>
	 <1387867304.3974.21.camel@slavad-ubuntu>
	 <20131226094853.GA27078@infradead.org>
	 <1388052949.4168.91.camel@slavad-ubuntu>
	 <20131226104532.GA11456@infradead.org>
Reply-To: slava@dubeyko.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from oproxy1-pub.mail.unifiedlayer.com ([66.147.249.253]:43686 "HELO
	oproxy1-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1751831Ab3LZK7U (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 26 Dec 2013 05:59:20 -0500
In-Reply-To: <20131226104532.GA11456@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2013-12-26 at 02:45 -0800, Christoph Hellwig wrote:

> So let's look at the case of a fgetxattr(fd, "osx.foo", ...) with the old
> and my new code.
> 
> Old:
> 
>  \---		sys_fgetxattr(fd, "osx.foo", ....
>   \			...
>    \---		generic_getxattr(dentry, "osx.foo", ...
>     \			[xattr_resolve_name strips the prefix]
>      \---	hfsplus_osx_getxattr(dentry, "foo", ...
>       \			[adds back prefix]
>        \		...
>         \---	__hfsplus_getxattr(dentry, "osx.foo", ...
> 	 \		[strips the prefix again]
> 	  \---	hfsplus_find_attr(sb, ino, "foo", ...
> 
> 
> New:
> 
>  \---		sys_fgetxattr(fd, "osx.foo", ....
>   \			...
>    \---		generic_getxattr(dentry, "osx.foo", ...
>     \			[xattr_resolve_name strips the prefix]
>      \---	hfsplus_osx_getxattr(dentry, "foo", ...
>       \			...
>        \---	__hfsplus_getxattr(dentry, "foo", ...
>         \---	hfsplus_find_attr(sb, ino, "foo", ...
> 

Great. :) Thank you for explanation.

So, the patch is fully correct for the new scheme of name resolving.

Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>

Thanks,
Vyacheslav Dubeyko.