From: Josef Bacik <jbacik@fb.com>
To: <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>
Subject: [PATCH] shmem: init on stack vmas
Date: Mon, 13 Jan 2014 13:46:17 -0500 [thread overview]
Message-ID: <1389638777-31891-1-git-send-email-jbacik@fb.com> (raw)
We were hitting a weird bug with our cgroup stuff because shmem uses on stack
vmas. These aren't properly init'ed so we'd have garbage in vma->mm and bad
things would happen. Fix this by just init'ing to empty structs. Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
mm/shmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 902a148..ee6b834 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -911,7 +911,7 @@ static struct mempolicy *shmem_get_sbmpol(struct shmem_sb_info *sbinfo)
static struct page *shmem_swapin(swp_entry_t swap, gfp_t gfp,
struct shmem_inode_info *info, pgoff_t index)
{
- struct vm_area_struct pvma;
+ struct vm_area_struct pvma = {};
struct page *page;
/* Create a pseudo vma that just contains the policy */
@@ -932,7 +932,7 @@ static struct page *shmem_swapin(swp_entry_t swap, gfp_t gfp,
static struct page *shmem_alloc_page(gfp_t gfp,
struct shmem_inode_info *info, pgoff_t index)
{
- struct vm_area_struct pvma;
+ struct vm_area_struct pvma = {};
struct page *page;
/* Create a pseudo vma that just contains the policy */
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-01-13 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 18:46 Josef Bacik [this message]
2014-01-13 20:32 ` [PATCH] shmem: init on stack vmas Dave Hansen
2014-01-13 20:35 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389638777-31891-1-git-send-email-jbacik@fb.com \
--to=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).