From: Jeff Layton <jlayton@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: nfs-ganesha-devel@lists.sourceforge.net,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 12/14] locks: pass the cmd value to fcntl_getlk/getlk64
Date: Tue, 14 Jan 2014 14:06:52 -0500 [thread overview]
Message-ID: <1389726414-30990-13-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1389726414-30990-1-git-send-email-jlayton@redhat.com>
Once we introduce file private locks, we'll need to know what cmd value
was used, as that affects the ownership and whether a conflict would
arise.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/fcntl.c | 4 ++--
fs/locks.c | 4 ++--
include/linux/fs.h | 10 ++++++----
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index ef68665..7ef7f2d 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -273,7 +273,7 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
err = setfl(fd, filp, arg);
break;
case F_GETLK:
- err = fcntl_getlk(filp, (struct flock __user *) arg);
+ err = fcntl_getlk(filp, cmd, (struct flock __user *) arg);
break;
case F_SETLK:
case F_SETLKW:
@@ -389,7 +389,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, cmd,
switch (cmd) {
case F_GETLK64:
- err = fcntl_getlk64(f.file, (struct flock64 __user *) arg);
+ err = fcntl_getlk64(f.file, cmd, (struct flock64 __user *) arg);
break;
case F_SETLK64:
case F_SETLKW64:
diff --git a/fs/locks.c b/fs/locks.c
index 5953b2c..f8cd6d7 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1898,7 +1898,7 @@ static void posix_lock_to_flock64(struct flock64 *flock, struct file_lock *fl)
/* Report the first existing lock that would conflict with l.
* This implements the F_GETLK command of fcntl().
*/
-int fcntl_getlk(struct file *filp, struct flock __user *l)
+int fcntl_getlk(struct file *filp, unsigned int cmd, struct flock __user *l)
{
struct file_lock file_lock;
struct flock flock;
@@ -2066,7 +2066,7 @@ out:
/* Report the first existing lock that would conflict with l.
* This implements the F_GETLK command of fcntl().
*/
-int fcntl_getlk64(struct file *filp, struct flock64 __user *l)
+int fcntl_getlk64(struct file *filp, unsigned int cmd, struct flock64 __user *l)
{
struct file_lock file_lock;
struct flock64 flock;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 639a3b7..d9bc9b5 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -993,12 +993,12 @@ struct file_lock {
extern void send_sigio(struct fown_struct *fown, int fd, int band);
#ifdef CONFIG_FILE_LOCKING
-extern int fcntl_getlk(struct file *, struct flock __user *);
+extern int fcntl_getlk(struct file *, unsigned int, struct flock __user *);
extern int fcntl_setlk(unsigned int, struct file *, unsigned int,
struct flock __user *);
#if BITS_PER_LONG == 32
-extern int fcntl_getlk64(struct file *, struct flock64 __user *);
+extern int fcntl_getlk64(struct file *, unsigned int, struct flock64 __user *);
extern int fcntl_setlk64(unsigned int, struct file *, unsigned int,
struct flock64 __user *);
#endif
@@ -1031,7 +1031,8 @@ extern int lease_modify(struct file_lock **, int);
extern int lock_may_read(struct inode *, loff_t start, unsigned long count);
extern int lock_may_write(struct inode *, loff_t start, unsigned long count);
#else /* !CONFIG_FILE_LOCKING */
-static inline int fcntl_getlk(struct file *file, struct flock __user *user)
+static inline int fcntl_getlk(struct file *file, unsigned int cmd,
+ struct flock __user *user)
{
return -EINVAL;
}
@@ -1043,7 +1044,8 @@ static inline int fcntl_setlk(unsigned int fd, struct file *file,
}
#if BITS_PER_LONG == 32
-static inline int fcntl_getlk64(struct file *file, struct flock64 __user *user)
+static inline int fcntl_getlk64(struct file *file, unsigned int cmd,
+ struct flock64 __user *user)
{
return -EINVAL;
}
--
1.8.4.2
next prev parent reply other threads:[~2014-01-14 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 19:06 [PATCH v6 00/14] locks: implement "file-private" (aka UNPOSIX) locks Jeff Layton
2014-01-14 19:06 ` [PATCH v6 01/14] locks: close potential race between setlease and open Jeff Layton
2014-01-14 19:06 ` [PATCH v6 02/14] locks: clean up comment typo Jeff Layton
2014-01-14 19:06 ` [PATCH v6 03/14] locks: remove "inline" qualifier from fl_link manipulation functions Jeff Layton
2014-01-14 19:06 ` [PATCH v6 04/14] locks: add __acquires and __releases annotations to locks_start and locks_stop Jeff Layton
2014-01-14 19:06 ` [PATCH v6 05/14] locks: eliminate BUG() call when there's an unexpected lock on file close Jeff Layton
2014-01-14 19:06 ` [PATCH v6 06/14] locks: fix posix lock range overflow handling Jeff Layton
2014-01-14 19:06 ` [PATCH v6 07/14] locks: consolidate checks for compatible filp->f_mode values in setlk handlers Jeff Layton
2014-01-14 19:06 ` [PATCH v6 08/14] MAINTAINERS: add Bruce and myself to list of maintainers for file locking code Jeff Layton
2014-01-14 19:06 ` [PATCH v6 09/14] locks: rename locks_remove_flock to locks_remove_file Jeff Layton
2014-01-14 19:06 ` [PATCH v6 10/14] locks: make /proc/locks show IS_FILE_PVT locks with a P suffix Jeff Layton
2014-01-14 19:06 ` [PATCH v6 11/14] locks: report l_pid as -1 for FL_FILE_PVT locks Jeff Layton
2014-01-14 19:06 ` Jeff Layton [this message]
2014-01-14 19:06 ` [PATCH v6 13/14] locks: skip deadlock detection on " Jeff Layton
2014-01-14 19:06 ` [PATCH v6 14/14] locks: add new fcntl cmd values for handling file private locks Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389726414-30990-13-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).