* [PATCH] nfs: fix setting of ACLs on file creation.
@ 2014-01-31 2:31 Noah Massey
[not found] ` <1391135472-9639-1-git-send-email-Noah.Massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Noah Massey @ 2014-01-31 2:31 UTC (permalink / raw)
To: Al Viro, Trond Myklebust
Cc: Noah Massey, Christoph Hellwig, linux-nfs-u79uwXL29TY76Z2rM5mHXA,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA
From: Noah Massey <noah.massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
nfs3_get_acl() tries to skip posix equivalent ACLs, but misinterprets
the return value of posix_acl_equiv_mode(). Fix it.
This is a regression introduced by
"nfs: use generic posix ACL infrastructure for v3 Posix ACLs"
CC: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
CC: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
fs/nfs/nfs3acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
index 9a5ca03..0851f85 100644
--- a/fs/nfs/nfs3acl.c
+++ b/fs/nfs/nfs3acl.c
@@ -80,7 +80,7 @@ struct posix_acl *nfs3_get_acl(struct inode *inode, int type)
}
if (res.acl_access != NULL) {
- if (posix_acl_equiv_mode(res.acl_access, NULL) ||
+ if ((posix_acl_equiv_mode(res.acl_access, NULL) == 0) ||
res.acl_access->a_count == 0) {
posix_acl_release(res.acl_access);
res.acl_access = NULL;
--
1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: fix setting of ACLs on file creation.
[not found] ` <1391135472-9639-1-git-send-email-Noah.Massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2014-02-03 7:56 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2014-02-03 7:56 UTC (permalink / raw)
To: Noah Massey
Cc: Al Viro, Trond Myklebust, Christoph Hellwig,
linux-nfs-u79uwXL29TY76Z2rM5mHXA,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA
On Thu, Jan 30, 2014 at 09:31:12PM -0500, Noah Massey wrote:
> From: Noah Massey <noah.massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> nfs3_get_acl() tries to skip posix equivalent ACLs, but misinterprets
> the return value of posix_acl_equiv_mode(). Fix it.
>
> This is a regression introduced by
> "nfs: use generic posix ACL infrastructure for v3 Posix ACLs"
Thanks for catching this Noah!
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-03 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-31 2:31 [PATCH] nfs: fix setting of ACLs on file creation Noah Massey
[not found] ` <1391135472-9639-1-git-send-email-Noah.Massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-03 7:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).