From: Oleg Drokin <green@linuxhacker.ru>
To: linux-kernel@vger.kernel.org, jlayton@redhat.com,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Cc: Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH] Fix mountpoint reference leakage in linkat
Date: Fri, 31 Jan 2014 15:41:58 -0500 [thread overview]
Message-ID: <1391200918-29185-1-git-send-email-green@linuxhacker.ru> (raw)
Recent changes to retry on ESTALE in linkat
(commit 442e31ca5a49e398351b2954b51f578353fdf210)
introduced a mountpoint reference leak and a small memory
leak in case a filesystem link operation returns ESTALE
which is pretty normal for distributed filesystems like
lustre, nfs and so on.
Free old_path in such a case.
Signed-off-by: Oleg Drokin: <green@linuxhacker.ru>
---
fs/namei.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/namei.c b/fs/namei.c
index bcb838e..e620937 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3931,6 +3931,7 @@ out_dput:
goto retry;
}
if (retry_estale(error, how)) {
+ path_put(&old_path);
how |= LOOKUP_REVAL;
goto retry;
}
--
1.8.5.3
next reply other threads:[~2014-01-31 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 20:41 Oleg Drokin [this message]
2014-01-31 20:52 ` [PATCH] Fix mountpoint reference leakage in linkat Jeff Layton
2014-01-31 21:03 ` Al Viro
2014-01-31 21:13 ` Oleg Drokin
2014-01-31 21:32 ` Jeff Layton
2014-01-31 21:50 ` Oleg Drokin
2014-01-31 22:30 ` Al Viro
2014-01-31 22:34 ` [PATCH v2] vfs: " Oleg Drokin
2014-01-31 23:11 ` [PATCH] " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391200918-29185-1-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).