From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality
Date: Thu, 06 Feb 2014 10:21:19 +0400
Message-ID: <1391667679.15555.3.camel@ubuntu>
References: <1390577118.2287.64.camel@slavad-ubuntu-12.04>
	 <20140205154833.be220231580431b148c370f3@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	ChristophHellwig <hch@infradead.org>,
	Hin-Tak Leung <htl10@users.sourceforge.net>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:43846 "HELO
	gproxy2-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1751850AbaBFGV5 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 6 Feb 2014 01:21:57 -0500
In-Reply-To: <20140205154833.be220231580431b148c370f3@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote:
> On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> 
> > This second version of patchset that implements journal replay
> > functionality in HFS+ file system driver.
> 
> The series introduces a lot of build glitches on i386 (and other 32-bit
> builds)
> 
> - tons of printk mismatch warnings
> 
> - unresolvable references to __udivdi3 and __umoddi3 (need to use
>   do_div() or similar).
> 
> - several bisection holes:
> 
>   - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE'
> 
>   - with three patches applied, warning: 'hfsplus_create_journal' used but never defined
> 
> and probably others.
> 
> I'll drop the series for now.  Please, find an i386 compiler and ensure
> that we get a clean build at every point of the patch series.
> 
> 
> To find the __udivdi3 thing I do something like
> 
> 	make M=fs/hfsplus
> 	grep __udivdi3 fs/hfsplus/*.o
> 
> then for the offending .o file
> 
> 	make fs/hfsplus/foo.s (or foo.lst)
> 
> then poke around in the assembly code to locate the offending function.

Ok. Thank you. I'll check patchset building on i386 platform and I'll
fix all found errors.

Thanks,
Vyacheslav Dubeyko.