public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	ChristophHellwig <hch@infradead.org>,
	Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality
Date: Fri, 07 Feb 2014 10:05:44 +0400	[thread overview]
Message-ID: <1391753144.15555.44.camel@ubuntu> (raw)
In-Reply-To: <1391667679.15555.3.camel@ubuntu>

Hi Andrew,

On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote:
> On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote:
> > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> > 
> > > This second version of patchset that implements journal replay
> > > functionality in HFS+ file system driver.
> > 
> > The series introduces a lot of build glitches on i386 (and other 32-bit
> > builds)
> > 
> > - tons of printk mismatch warnings
> > 
> > - unresolvable references to __udivdi3 and __umoddi3 (need to use
> >   do_div() or similar).
> > 
> > - several bisection holes:
> > 
> >   - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE'
> > 
> >   - with three patches applied, warning: 'hfsplus_create_journal' used but never defined
> > 

I've reproduced (1) printk mismatch warnings; and (2) unresolvable
references to __udivdi3 and __umoddi3 build issues. But I am unable to
reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I
assume that I misunderstand something. This declarations live inside of
journal.c file only. And I add journal.c file in Makefile in
0015-hfsplus-integrate-journal-replay-support-into-driver.patch only.
So, how do you achieve build issues with JHDR_SIZE and
hfsplus_create_journal? Could you share your way? Maybe do you use some
special compilation options or additional tools during build?

Thanks,
Vyacheslav Dubeyko.



  reply	other threads:[~2014-02-07  6:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 15:25 [PATCH v2 00/15] hfsplus: introduce journal replay functionality Vyacheslav Dubeyko
2014-01-27  4:22 ` Hin-Tak Leung
2014-01-27 13:25   ` Vyacheslav Dubeyko
2014-02-05 13:16     ` Hin-Tak Leung
2014-02-05 23:48 ` Andrew Morton
2014-02-06  6:21   ` Vyacheslav Dubeyko
2014-02-07  6:05     ` Vyacheslav Dubeyko [this message]
2014-02-07  6:23       ` Andrew Morton
2014-02-11  7:29       ` Hin-Tak Leung
2014-02-11  8:02         ` Vyacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391753144.15555.44.camel@ubuntu \
    --to=slava@dubeyko.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox