From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality
Date: Fri, 07 Feb 2014 10:05:44 +0400
Message-ID: <1391753144.15555.44.camel@ubuntu>
References: <1390577118.2287.64.camel@slavad-ubuntu-12.04>
	 <20140205154833.be220231580431b148c370f3@linux-foundation.org>
	 <1391667679.15555.3.camel@ubuntu>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	ChristophHellwig <hch@infradead.org>,
	Hin-Tak Leung <htl10@users.sourceforge.net>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:47286 "HELO
	gproxy2-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1750707AbaBGGGL (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 7 Feb 2014 01:06:11 -0500
In-Reply-To: <1391667679.15555.3.camel@ubuntu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi Andrew,

On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote:
> On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote:
> > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> > 
> > > This second version of patchset that implements journal replay
> > > functionality in HFS+ file system driver.
> > 
> > The series introduces a lot of build glitches on i386 (and other 32-bit
> > builds)
> > 
> > - tons of printk mismatch warnings
> > 
> > - unresolvable references to __udivdi3 and __umoddi3 (need to use
> >   do_div() or similar).
> > 
> > - several bisection holes:
> > 
> >   - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE'
> > 
> >   - with three patches applied, warning: 'hfsplus_create_journal' used but never defined
> > 

I've reproduced (1) printk mismatch warnings; and (2) unresolvable
references to __udivdi3 and __umoddi3 build issues. But I am unable to
reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I
assume that I misunderstand something. This declarations live inside of
journal.c file only. And I add journal.c file in Makefile in
0015-hfsplus-integrate-journal-replay-support-into-driver.patch only.
So, how do you achieve build issues with JHDR_SIZE and
hfsplus_create_journal? Could you share your way? Maybe do you use some
special compilation options or additional tools during build?

Thanks,
Vyacheslav Dubeyko.