From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hin-Tak Leung Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality Date: Tue, 11 Feb 2014 07:29:37 +0000 (GMT) Message-ID: <1392103777.56890.YahooMailBasic@web172306.mail.ir2.yahoo.com> References: <1391753144.15555.44.camel@ubuntu> Reply-To: htl10@users.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linux FS devel list , Al Viro , ChristophHellwig To: Andrew Morton , Vyacheslav Dubeyko Return-path: Received: from nm32-vm8.bullet.mail.ir2.yahoo.com ([212.82.97.104]:29415 "EHLO nm32-vm8.bullet.mail.ir2.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbaBKH3j convert rfc822-to-8bit (ORCPT ); Tue, 11 Feb 2014 02:29:39 -0500 In-Reply-To: <1391753144.15555.44.camel@ubuntu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: -------------------------------------------- On Fri, 7/2/14, Vyacheslav Dubeyko wrote: Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functi= onality To: "Andrew Morton" Cc: "Linux FS devel list" , "Al Viro" <= viro@zeniv.linux.org.uk>, "ChristophHellwig" , "Hin-= Tak Leung" Date: Friday, 7 February, 2014, 6:05 =20 Hi Andrew, =20 On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote: > On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote: > > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko wrote: > >=20 > > > This second version of patchset that implements journal replay > > > functionality in HFS+ file system driver. > >=20 > > The series introduces a lot of build glitches on i386 (and other 32-bit > > builds) > >=20 > > - tons of printk mismatch warnings > >=20 > > - unresolvable references to __udivdi3 and __umoddi3 (need to use > >=A0=A0=A0do_div() or similar). > >=20 > > - several bisection holes: > >=20 > >=A0=A0=A0- with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE' > >=20 > >=A0=A0=A0- with three patches applied, warning: 'hfsplus_create_journal' used but never defined > >=20 =20 I've reproduced (1) printk mismatch warnings; and (2) unresolvable references to __udivdi3 and __umoddi3 build issues. But I am unable to reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I assume that I misunderstand something. This declarations live inside of journal.c file only. And I add journal.c file in Makefile in 0015-hfsplus-integrate-journal-replay-support-into-driver.patch only. So, how do you achieve build issues with JHDR_SIZE and hfsplus_create_journal? Could you share your way? Maybe do you use some special compilation options or additional tools during build? =20 Thanks, Vyacheslav Dubeyko. =20 Hi Vyacheslav, I came across this patch (http://marc.info/?l=3Dlinux-fsdevel&m=3D13844= 6099500610&w=3D2) about an earlier __divdi3 issue - the analysis is quite thorough and I = think relevant for the __udivdi3 / __umoddi3 issues. Hope this helps. Hin-Tak =20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html