Re: [PATCH v3 01/15] hfsplus: add necessary declarations for journal replay

[Vyacheslav Dubeyko <slava@dubeyko.com>]

On Thu, 2014-02-13 at 20:07 +0000, Hin-Tak Leung wrote:
>  
>  Hi all,
> 
> I Have mentioned earlier that I have the powerpc version of Darwin 8 (equivalent
> to Mac OS X 10.4) running inside pearpc, and have other uses of it and therefore have given it
> some use. I can look into this - and probably will, when I try v3 of  Vyacheslav's patch set.
> 

So, had you any error messages when you tried patchset v3? If you really
have HFS+ volume with big-endian structures in journal then failure with
journal replay or volume corruption is inevitable.

> Darwin 8 does certainly noticed it was uncleanly shut down and display a message about
> journal replay the next time it starts; also it seems to notice the journal had been played
> with by somebody else - there is a message about invalid/invalidating journal entries
> when I ran fsck.hfsplus manually between unclean shut down and restart.
> (That's assuming  fsck.hfsplus can cope with disk images written by the powerpc
> version of darwin 8 correctly, one way or another - I should hope so, as it is
> not unthinkable for a mac user to own both kind of macs).
> 
> So it appears that the journal is not emptied by fsck.hfsplus, but simply marked done
> and no longer relevant, and the darwin kernel code notices that.
> 

As far as I can judge, fsck tool doesn't replay journal, usually. It
need to take into account presence of journal with transactions. But
namely file system driver is responsible for journal replay. And, as I
remember correctly, fsck.hfsplus claims about presence of journal and it
suggests to use force option for volume checking in such case.

Thanks,
Vyacheslav Dubeyko.