* [PATCH 1/1] HFSPLUS: add __init to hfsplus_create_attr_tree_cache()
@ 2014-03-10 20:56 Fabian Frederick
2014-03-11 6:38 ` Vyacheslav Dubeyko
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-03-10 20:56 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, linux-fsdevel
hfsplus_create_attr_tree_cache is only called by __init init_hfsplus_fs
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/hfsplus/attributes.c | 2 +-
fs/hfsplus/hfsplus_fs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/hfsplus/attributes.c b/fs/hfsplus/attributes.c
index 0f47890..caf89a7 100644
--- a/fs/hfsplus/attributes.c
+++ b/fs/hfsplus/attributes.c
@@ -11,7 +11,7 @@
static struct kmem_cache *hfsplus_attr_tree_cachep;
-int hfsplus_create_attr_tree_cache(void)
+int __init hfsplus_create_attr_tree_cache(void)
{
if (hfsplus_attr_tree_cachep)
return -EEXIST;
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
index 08846425b..bb75586 100644
--- a/fs/hfsplus/hfsplus_fs.h
+++ b/fs/hfsplus/hfsplus_fs.h
@@ -366,7 +366,7 @@ typedef int (*search_strategy_t)(struct hfs_bnode *,
*/
/* attributes.c */
-int hfsplus_create_attr_tree_cache(void);
+int __init hfsplus_create_attr_tree_cache(void);
void hfsplus_destroy_attr_tree_cache(void);
hfsplus_attr_entry *hfsplus_alloc_attr_entry(void);
void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry_p);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] HFSPLUS: add __init to hfsplus_create_attr_tree_cache()
2014-03-10 20:56 [PATCH 1/1] HFSPLUS: add __init to hfsplus_create_attr_tree_cache() Fabian Frederick
@ 2014-03-11 6:38 ` Vyacheslav Dubeyko
0 siblings, 0 replies; 2+ messages in thread
From: Vyacheslav Dubeyko @ 2014-03-11 6:38 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, akpm, linux-fsdevel
On Mon, 2014-03-10 at 21:56 +0100, Fabian Frederick wrote:
> hfsplus_create_attr_tree_cache is only called by __init init_hfsplus_fs
>
I think that it is the reasonable fix. Looks good for me.
Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Vyacheslav Dubeyko.
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/hfsplus/attributes.c | 2 +-
> fs/hfsplus/hfsplus_fs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/attributes.c b/fs/hfsplus/attributes.c
> index 0f47890..caf89a7 100644
> --- a/fs/hfsplus/attributes.c
> +++ b/fs/hfsplus/attributes.c
> @@ -11,7 +11,7 @@
>
> static struct kmem_cache *hfsplus_attr_tree_cachep;
>
> -int hfsplus_create_attr_tree_cache(void)
> +int __init hfsplus_create_attr_tree_cache(void)
> {
> if (hfsplus_attr_tree_cachep)
> return -EEXIST;
> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
> index 08846425b..bb75586 100644
> --- a/fs/hfsplus/hfsplus_fs.h
> +++ b/fs/hfsplus/hfsplus_fs.h
> @@ -366,7 +366,7 @@ typedef int (*search_strategy_t)(struct hfs_bnode *,
> */
>
> /* attributes.c */
> -int hfsplus_create_attr_tree_cache(void);
> +int __init hfsplus_create_attr_tree_cache(void);
> void hfsplus_destroy_attr_tree_cache(void);
> hfsplus_attr_entry *hfsplus_alloc_attr_entry(void);
> void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry_p);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-11 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-10 20:56 [PATCH 1/1] HFSPLUS: add __init to hfsplus_create_attr_tree_cache() Fabian Frederick
2014-03-11 6:38 ` Vyacheslav Dubeyko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).