linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Al Viro <viro@ZenIV.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	akpm@linux-foundation.org
Subject: Re: [PATCH] autofs4: check dev ioctl size before allocating
Date: Sun, 06 Apr 2014 11:53:57 +0800	[thread overview]
Message-ID: <1396756437.24991.6.camel@perseus.fritz.box> (raw)
In-Reply-To: <5340C5C7.9010203@oracle.com>

On Sat, 2014-04-05 at 23:11 -0400, Sasha Levin wrote:
> On 04/05/2014 11:03 PM, Ian Kent wrote:
> > On Sat, 2014-04-05 at 11:06 -0400, Sasha Levin wrote:
> >> Ping? Anyone wants to take this?
> > 
> > Is this causing a problem for users?
> > If it is I'll send it to Andrew straight away.
> > 
> > I do have this on my queue but don't have any other patches to send so
> > it's just sitting there.
> > 
> > If it worries you I'll send it to Andrew now.
> 
> It's not really a pressing issue since /dev/autofs is accessible only to
> root. I also doubt that it causes problems for actual users.
> 
> If there are no issues with the patch, I think it's best if you could
> ack/sign off on it and if Andrew wants to take it now, he could. If he
> doesn't, it could wait for whenever.
> 
> I just don't want it getting lost somewhere and never making it upstream.

OK, but since I'm going to send it I looked at it a bit closer.
Shouldn't the E2BIG be ENAMETOOLONG since it's a file path that's being
passed?

I can change that and send it if you agree with the change.

Ian


  reply	other threads:[~2014-04-06  3:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1394934021-16965-1-git-send-email-sasha.levin@oracle.com>
2014-04-05 15:06 ` [PATCH] autofs4: check dev ioctl size before allocating Sasha Levin
2014-04-06  3:03   ` Ian Kent
2014-04-06  3:11     ` Sasha Levin
2014-04-06  3:53       ` Ian Kent [this message]
2014-04-07  0:03         ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396756437.24991.6.camel@perseus.fritz.box \
    --to=raven@themaw.net \
    --cc=akpm@linux-foundation.org \
    --cc=autofs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).