linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vyacheslav Dubeyko <slava@dubeyko.com>
To: htl10@users.sourceforge.net
Cc: anton@tuxera.com, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH V2] hfsplus: fixes worst-case unicode to char conversion of file names and attributes
Date: Wed, 09 Apr 2014 10:46:17 +0400	[thread overview]
Message-ID: <1397025977.2062.10.camel@slavad-CELSIUS-H720> (raw)
In-Reply-To: <1396986794.16777.YahooMailBasic@web172304.mail.ir2.yahoo.com>

On Tue, 2014-04-08 at 20:53 +0100, Hin-Tak Leung wrote:

[snip]

> 
> If you insist on doing Chinese all the way, 127/3 = 42 is really a bit low for a
> descriptive string of any usage, but does anybody use non-english extended
> attributes on any OSes?
> 

If you think that nobody use non-english extended attributes then it
doesn't make sense to make any fixes in xattr subsystem of HFS+. And
partial code changing in hfsplus_listxattr() is completely useless.
Because getxattr() and setxattr() series of methods will be the primary
source of error in the case of worst-case unicode to char conversion.

Otherwise, you can use any splitting of fixes between patches. In my
last e-mail I suggested to use kmem cache approach for xattr names
instead of kmalloc only.

Thanks,
Vyacheslav Dubeyko.



  reply	other threads:[~2014-04-09  6:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 19:53 [PATCH V2] hfsplus: fixes worst-case unicode to char conversion of file names and attributes Hin-Tak Leung
2014-04-09  6:46 ` Vyacheslav Dubeyko [this message]
2014-04-09  8:58   ` Anton Altaparmakov
2014-04-10  7:04     ` Vyacheslav Dubeyko
2014-04-10  9:13       ` Anton Altaparmakov
  -- strict thread matches above, loose matches on Subject: below --
2014-04-10 14:42 Hin-Tak Leung
2014-04-09 14:28 Hin-Tak Leung
2014-04-10  7:23 ` Vyacheslav Dubeyko
2014-04-08 16:43 Hin-Tak Leung
2014-04-08 16:55 ` Vyacheslav Dubeyko
2014-04-08 17:09   ` Anton Altaparmakov
2014-04-08 17:21     ` Vyacheslav Dubeyko
2014-04-08 16:07 Hin-Tak Leung
2014-04-08 14:42 Hin-Tak Leung
2014-04-08 14:08 Hin-Tak Leung
2014-04-08 14:41 ` Sergei Antonov
2014-04-08 13:37 Hin-Tak Leung
2014-04-08  2:19 Hin-Tak Leung
2014-04-08  7:05 ` Vyacheslav Dubeyko
2014-04-08 11:56 ` Sergei Antonov
2014-04-08 15:06 ` Anton Altaparmakov
2014-04-08 16:15   ` Vyacheslav Dubeyko
2014-04-08 16:59 ` Sergei Antonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397025977.2062.10.camel@slavad-CELSIUS-H720 \
    --to=slava@dubeyko.com \
    --cc=anton@tuxera.com \
    --cc=hch@infradead.org \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).