From: Hin-Tak Leung <hintak.leung@gmail.com>
To: linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: [PATCH 0/3] hfsplus: fix series for non-english names and attributes
Date: Thu, 17 Apr 2014 20:30:19 +0100 [thread overview]
Message-ID: <1397763022-791-1-git-send-email-HinTak.Leung@gmail.com> (raw)
From: Hin-Tak Leung <htl10@users.sourceforge.net>
This is a series of 3 patches which corrects issues in HFS+
concerning the use of non-english file names and attributes.
Names and attributes are stored internally as UTF-16 units up to a
fixed maximum size, and convert to and from user-representation by NLS.
The code incorrectly assume that NLS string lengths are equal
to unicode lengths, which is only true for English ascii usage.
This is largely a repost (with some editing/formatting to the messages) of the
earlier 4-patch series, as the original 4th patch
"hfsplus: fixes error propagation of hfsplus_asc2uni" is no longer needed.
The 4th patch is functionally identical to "hfsplus: fix longname handling"
from Sougata Santra posted a few weeks ago.
Patch 1 differs from the single patch sent to Andrew Morton by one
kzalloc to kmalloc change, as the kzalloc is not needed on examination.
The others only differ from the previous series of 4 posted to fs-devel
by editing/formatting and additions of CC's of the commit messages
- there is no code change.
Hin-Tak Leung (3):
hfsplus: fixes worst-case unicode to char conversion of file names and
attributes
hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English
attributes
hfsplus: remove unused routine hfsplus_attr_build_key_uni
fs/hfsplus/attributes.c | 36 ++++----------------------------
fs/hfsplus/dir.c | 11 ++++++++--
fs/hfsplus/hfsplus_fs.h | 3 ---
fs/hfsplus/xattr.c | 50 ++++++++++++++++++++++++++++++---------------
fs/hfsplus/xattr_security.c | 47 +++++++++++++++++++++++-------------------
fs/hfsplus/xattr_trusted.c | 30 ++++++++++++++++-----------
fs/hfsplus/xattr_user.c | 30 ++++++++++++++++-----------
7 files changed, 108 insertions(+), 99 deletions(-)
--
1.9.0
next reply other threads:[~2014-04-17 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 19:30 Hin-Tak Leung [this message]
2014-04-17 19:30 ` [PATCH 1/3] hfsplus: fixes worst-case unicode to char conversion of file names and attributes Hin-Tak Leung
2014-04-22 20:28 ` Andrew Morton
2014-04-17 19:30 ` [PATCH 2/3] hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes Hin-Tak Leung
2014-04-17 19:30 ` [PATCH 3/3] hfsplus: remove unused routine hfsplus_attr_build_key_uni Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397763022-791-1-git-send-email-HinTak.Leung@gmail.com \
--to=hintak.leung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=htl10@users.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).