From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominique Martinet Subject: [PATCH] 9P: fix return value in v9fs_fid_xattr_set Date: Wed, 21 May 2014 10:02:12 +0200 Message-ID: <1400659332-21498-1-git-send-email-dominique.martinet@cea.fr> References: <20140521065219.GA15962@u-barrelet> Cc: "Eric W. Biederman" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alin Dobre , Ron Minnich , Latchesar Ionkov , Dominique Martinet To: v9fs-developer@lists.sourceforge.net, Eric Van Hensbergen Return-path: In-Reply-To: <20140521065219.GA15962@u-barrelet> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org v9fs_fid_xattr_set is supposed to return 0 on success. This corrects the behaviour introduced in commit bdd5c28dcb8330b9074404cc92a0b83aae5606a "9p: fix return value in case in v9fs_fid_xattr_set()" (The function returns a negative error on error, as expected) Signed-off-by: Dominique Martinet --- fs/9p/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c index 04133a1..f95e01e 100644 --- a/fs/9p/xattr.c +++ b/fs/9p/xattr.c @@ -156,7 +156,7 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, offset += write_count; value_len -= write_count; } - retval = offset; + retval = 0; err: p9_client_clunk(fid); return retval; -- 1.9.0