linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yann Droneaud <ydroneaud@opteya.com>
To: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: ydroneaud@opteya.com
Subject: ecryptfs_privileged_open(): when kthread-ecryptfs is required ?
Date: Fri, 23 May 2014 16:24:05 +0200	[thread overview]
Message-ID: <1400855045.23090.25.camel@localhost.localdomain> (raw)

Hi,

While trying to investigate why using ecryptfs is painfully sluggish,
I've find a piece of code that, I believed at first, wouldn't scale.

After adding some printk() there, I've found that it's not at all 
called in my use case.
So I wonder: what's making  ecryptfs_privileged_open()[1] submit work 
to ecryptfs-kthread thread running ecryptfs_threadfn()[2] ?

[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/fs/ecryptfs/kthread.c#n155

[2]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/fs/ecryptfs/kthread.c#n56

BTW, I have a patch that remove this kernel thread as I think
credentials can be given to dentry_open(), so instead of running an
helper kthread, some privileged credentials can be given to
dentry_open() in the case ecryptfs_privileged_open() really need to 
open a file read/write. But as I'm not able to verify it's working as 
expected, I'm holding such trival patch.

Regards.

-- 
Yann Droneaud
OPTEYA

             reply	other threads:[~2014-05-23 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 14:24 Yann Droneaud [this message]
2014-05-26 13:53 ` ecryptfs_privileged_open(): when kthread-ecryptfs is required ? Tyler Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400855045.23090.25.camel@localhost.localdomain \
    --to=ydroneaud@opteya.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).