Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --]

On Sat, 2014-06-07 at 18:40 +0200, Ken Helias wrote:
> From: Ken Helias <kenhelias@firemail.de>
> 
> All other add functions for lists have the new item as first argument
> and the
> position where it is added as second argument. This was changed for no
> good
> reason in this function and makes using it unnecessary confusing.
> 
> The name was changed to let old code generate a compile errors instead
> of
> using the wrong parameter order.
> 
> Signed-off-by: Ken Helias <kenhelias@firemail.de>
> Cc: Linux NICS <linux.nics@intel.com>
> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: e1000-devel@lists.sourceforge.net
> Cc: netdev@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: linux-fsdevel@vger.kernel.org
> Cc: b.a.t.m.a.n@lists.open-mesh.org
> Cc: bridge@lists.linux-foundation.org

For the Intel driver changes...
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

> ---
> Patch based on "Add linux-next specific files for 20140606"
> 
> v3:
> renamed from hlist_add_after* to hlist_add_behind
> 
> v2:
> Splitted into two patches
> reduced number of Cc
> 
>  Documentation/RCU/whatisRCU.txt                  | 2 +-
>  drivers/gpu/drm/drm_hashtab.c                    | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c   | 2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +-
>  drivers/staging/lustre/lustre/libcfs/hash.c      | 4 ++--
>  fs/namespace.c                                   | 2 +-
>  fs/notify/inode_mark.c                           | 2 +-
>  fs/notify/vfsmount_mark.c                        | 2 +-
>  include/linux/list.h                             | 4 ++--
>  include/linux/rculist.h                          | 8 ++++----
>  net/batman-adv/fragmentation.c                   | 2 +-
>  net/bridge/br_multicast.c                        | 2 +-
>  net/ipv4/fib_trie.c                              | 2 +-
>  net/ipv6/addrlabel.c                             | 2 +-
>  net/xfrm/xfrm_policy.c                           | 4 ++--
>  15 files changed, 21 insertions(+), 21 deletions(-)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel