From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Marek Vasut <marex@denx.de>,
Tadeusz Struk <tadeusz.struk@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Helge Deller <deller@gmx.de>,
Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>,
linux390@de.ibm.com, Alexander Viro <viro@zeniv.linux.org.uk>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-media@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()
Date: Thu, 10 Jul 2014 03:01:43 -0700 [thread overview]
Message-ID: <1404986503.8839.24.camel@joe-AO725> (raw)
In-Reply-To: <1404985839.5102.97.camel@smile.fi.intel.com>
On Thu, 2014-07-10 at 12:50 +0300, Andy Shevchenko wrote:
> I have considered to modify hex_dump_to_buffer() to return how many
> bytes it actually proceed to the buffer. In that case we can directly
> print to m->buf like other seq_<foo> calls do.
>
> But I still have doubts about it. Any opinion?
Simpler is better.
next prev parent reply other threads:[~2014-07-10 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 15:24 [PATCH v1 0/5] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
2014-07-09 15:24 ` [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump() Andy Shevchenko
2014-07-09 20:39 ` Marek Vasut
2014-07-09 21:21 ` Joe Perches
2014-07-10 7:58 ` Marek Vasut
2014-07-10 9:50 ` Andy Shevchenko
2014-07-10 10:01 ` Joe Perches [this message]
2014-07-09 15:24 ` [PATCH v1 2/5] saa7164: convert to seq_hex_dump() Andy Shevchenko
2014-07-09 18:24 ` Steven Toth
2014-07-26 18:12 ` Mauro Carvalho Chehab
2014-07-09 15:24 ` [PATCH v1 3/5] crypto: qat - use seq_hex_dump() to dump buffers Andy Shevchenko
[not found] ` <53BD8A9F.4030409@intel.com>
2014-07-10 11:20 ` Andy Shevchenko
2014-07-09 15:24 ` [PATCH v1 4/5] parisc: " Andy Shevchenko
2014-07-09 18:26 ` Joe Perches
2014-07-09 20:40 ` Andy Shevchenko
2014-07-09 15:24 ` [PATCH v1 5/5] [S390] zcrypt: " Andy Shevchenko
2014-07-10 9:56 ` Andy Shevchenko
2014-07-09 18:26 ` [PATCH v1 0/5] fs/seq_file: introduce seq_hex_dump() helper Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404986503.8839.24.camel@joe-AO725 \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=deller@gmx.de \
--cc=herbert@gondor.apana.org.au \
--cc=ingo.tuchscherer@de.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=m.chehab@samsung.com \
--cc=marex@denx.de \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).