From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: direct-io: squelch maybe-uninitialized warning in do_direct_IO() Date: Thu, 17 Jul 2014 11:54:22 +0200 Message-ID: <1405590862.4808.22.camel@x220> References: <1404452632-10912-1-git-send-email-pramod.gurav.etc@gmail.com> <20140713115022.GA6054@infradead.org> <53C6B199.2070606@gmail.com> <20140716175803.GA3631@infradead.org> <1405536124.4357.17.camel@x41> <53C79949.7010201@gmail.com> <53C79A1C.5060402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Borislav Petkov , Sam Ravnborg , pramod.gurav.etc@gmail.com, Jason Cooper , Markus Mayer , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Boaz Harrosh Return-path: Received: from cpsmtpb-ews05.kpnxchange.com ([213.75.39.8]:60165 "EHLO cpsmtpb-ews05.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754044AbaGQJyZ (ORCPT ); Thu, 17 Jul 2014 05:54:25 -0400 In-Reply-To: <53C79A1C.5060402@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Boaz, On Thu, 2014-07-17 at 12:40 +0300, Boaz Harrosh wrote: > > Signed-off-by: Paul Bolle > > Paul this is your patch I put you as Signed-off-by please acknowledge I never signed off on that patch! Speaking from memory, I just sent a message stating that "something like this" might silence the warning. I also stated that I needed to have another look at it. This touches code I did not write and do not yet understand well enough. Getting there requires a clean schedule, clean head, and/or a clean desk. I certainly won't sign off on it until one or more of those conditions are met. Please don't do this (adding a Signed-off-by on a patch I drafted) again! Paul Bolle