From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sougata Santra Subject: Re: [PATCH 1/1] hfsplus: skip unnecessary volume header sync Date: Fri, 18 Jul 2014 12:49:49 +0300 Message-ID: <1405676989.25052.42.camel@ultrabook> References: <1405614762.25052.8.camel@ultrabook> <20140717135929.1a9fa7279cbb4e7a57761213@linux-foundation.org> <1405672537.25052.18.camel@ultrabook> <1405674110.2626.39.camel@slavad-CELSIUS-H720> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , , , Fabian Frederick To: Vyacheslav Dubeyko Return-path: Received: from nbl-ex10-fe01.nebula.fi ([188.117.32.121]:63576 "EHLO ex10.nebula.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755228AbaGRJtv (ORCPT ); Fri, 18 Jul 2014 05:49:51 -0400 In-Reply-To: <1405674110.2626.39.camel@slavad-CELSIUS-H720> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2014-07-18 at 13:01 +0400, Vyacheslav Dubeyko wrote: > On Fri, 2014-07-18 at 11:35 +0300, Sougata Santra wrote: > > [snip] > > 2) Also, there was a error in error propagation. It it also fixed in > > this patch. > > -->snip<-- > > if (!error) > > error2 = error; > > -->snap<-- > > > > 3) The disk is only flushed if there was no error. Previously it was > > always flushed without checking the error. > > So, do you mean that filemap_write_and_wait() and hfsplus_submit_bio() > doesn't request writing on a volume? Yes it did, but it wrote in the page-cache ?. > What do you mean when you are > talking about absence of flush? I think that I have misunderstanding of > the description. AFAIK, blkdev_issue_flush() is issued to flush the write back cache of the block device if it supports REQUEST_FLUSH. I did not understand the need to flush the disk cache to send everything into non-volatile memory when writing to page-cache returned some error. If the error checking is not required, then I can remove it. > > Thanks, > Vyacheslav Dubeyko. > > Thanks a lot, Sougata.