From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Chen Subject: Re: [Regression 3.16-rc kernel] -55% reduction in throughput for OLTP benchmark Date: Thu, 31 Jul 2014 09:13:50 -0700 Message-ID: <1406823230.2970.946.camel@schen9-DESK> References: <1406584299.2970.924.camel@schen9-DESK> <20140729141908.GA4464@infradead.org> <1406651702.2970.927.camel@schen9-DESK> <20140729164951.GA23863@infradead.org> <1406678232.2970.943.camel@schen9-DESK> <20140730001248.GA32367@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Al Viro , suruchi , ak , Dave Hansen , Matthew Wilcox , "hubert.nueckel" , beth.marsh-prime@intel.com, "doug.nelson" , linux-kernel , linux-fsdevel , Linus Torvalds To: Christoph Hellwig Return-path: Received: from mga09.intel.com ([134.134.136.24]:35523 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442AbaGaQNx (ORCPT ); Thu, 31 Jul 2014 12:13:53 -0400 In-Reply-To: <20140730001248.GA32367@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2014-07-29 at 17:12 -0700, Christoph Hellwig wrote: > On Tue, Jul 29, 2014 at 04:57:12PM -0700, Tim Chen wrote: > > Christoph, we're glad to report that this patch does fix the problem. > > Wonder if Al or someone can pick it up. It is a large regression > > that should not be left unfixed for 3.16. > > Al has been away for a bit, and I prepared the last VFS pull. I'll pick > it up for now and either Al or I will send it on before next weekend. > > Can I get a tested-by tag from you for the patch? Can anyone else > please cross check it? The new total value might be different from > the old size value when we do a short write, but I can't see how > an async write would be a good thing if we had to finish the remainder > using buffered I/O if the old code really allowed that. > Yes, please put in Tested-by: Tim Chen Tested-by: Suruchi Kadu Tim